Skip to content

Add storageclassDevices to Pod spec #20625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2020
Merged

Add storageclassDevices to Pod spec #20625

merged 1 commit into from
Mar 25, 2020

Conversation

bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Mar 20, 2020

Relates to #20482
The sample YAML definition file is missing storageClassDevices and CR cannot be created. This PR adds the necessary parameters to avoid error (The LocalVolume "local-disks" is invalid: spec.storageClassDevices: Required value) that occurs from oc create command.

@bobfuru bobfuru linked an issue Mar 20, 2020 that may be closed by this pull request
[enterprise-4.3] Edit suggested in file storage/persistent_storage/persistent-storage-local.adoc #20482
Closed
@bobfuru
Copy link
Contributor Author

bobfuru commented Mar 20, 2020

@liangxia PTAL

@bobfuru bobfuru added this to the Next Release milestone Mar 20, 2020
@openshift-docs-preview-bot
Copy link

The preview will be available shortly at:

@liangxia
Copy link
Member

@qinpingli PTAL

qinpingli
qinpingli reviewed Mar 23, 2020
View reviewed changes
@qinpingli
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2020
@bobfuru bobfuru merged commit 18bab2d into openshift:master Mar 25, 2020
@bobfuru bobfuru deleted the ISSUE-20482 branch March 25, 2020 15:41
@bobfuru
Copy link
Contributor Author

bobfuru commented Mar 25, 2020

/cherrypick enterprise-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 25, 2020
Merged
@openshift-cherrypick-robot
Copy link

@bobfuru: new pull request created: #20678

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru
Copy link
Contributor Author

bobfuru commented Mar 25, 2020

/cherrypick enterprise-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 25, 2020
Merged
@openshift-cherrypick-robot
Copy link

@bobfuru: new pull request created: #20679

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru
Copy link
Contributor Author

bobfuru commented Mar 25, 2020

Status was logged in comments: https://issues.redhat.com/browse/OSDOCS-950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinpingli qinpingli qinpingli left review comments

Assignees

@qinpingli qinpingli

Labels
branch/enterprise-4.3 branch/enterprise-4.4 lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

[enterprise-4.3] Edit suggested in file storage/persistent_storage/persistent-storage-local.adoc
6 participants
@bobfuru @openshift-docs-preview-bot @liangxia @qinpingli @openshift-cherrypick-robot @openshift-ci-robot