cnv: avoid documenting cnv-bridge-cni #20631
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of OpenShift 4.3, the standard bridge-cni and tuning-cni are support vlan filtering and static mac address, respectfully. We should direct user to use these standard CNIs and not the CNV-crafted ones. Signed-off-by: Dan Kenigsberg <[email protected]>
|
@duyanyan would you please keep me honest here, verifying that there is no need to use the cnv-crafted CNIs? |
|
@phoracek please approve this PR (or reject it if you think it is wrong) |
ousleyp
added
branch/enterprise-4.3
branch/enterprise-4.4
peer-review-done
ousleyp
approved these changes
Mar 24, 2020
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
If we want to switch to OpenShift's bridge and tuning plugins, we have to fully honor their API which is not based around NetworkAttachmentDefinition, but around their Network operator. That would require changes in our UI and in docs. I'm in favor of switching to OCP's CNIs, but this PR would be at the end of a bigger effort. We should not merge this at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of OpenShift 4.3, the standard bridge-cni and tuning-cni are support
vlan filtering and static mac address, respectfully. We should direct
user to use these standard CNIs and not the CNV-crafted ones.
Signed-off-by: Dan Kenigsberg [email protected]