Add Whereabouts CNI plug-in documentation #23057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The preview will be available shortly at: |
jboxman
force-pushed
the
whereabouts-cni
branch
3 times, most recently
from
6b7c0de to
a9273fc
Compare
|
@dougbtv, this is ready for review:
|
|
@weliang1, this PR includes Whereabouts, and configuration for |
|
/LGTM |
jboxman
added
the
peer-review-needed
networking/multiple_networks/understanding-multiple-networks.adoc
Outdated
Show resolved
Hide resolved
bergerhoffer
added
peer-review-done
|
@bergerhoffer thanks! |
|
New changes are detected. LGTM label has been removed. |
|
@weliang1, do you know if Whereabouts was backported to 4.4.z? Thanks! |
|
Going to merge into enterprise-4.5; Will hold to see if enterprise-4.4 is necessary. |
|
/cherry-pick enterprise-4.5 |
|
@jboxman: new pull request created: #23311 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was referenced Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #20605.
The goal of this PR is to add configuration options for the Whereabouts CNI plug-in. It can be used only through the ipam CNI plug-in as a child object. And the ipam CNI plug-in can be used only within other CNI plug-in configurations.
Because macvlan configuration is an outlier, it does not use
rawCNIConfig. This adds that approach for macvlan so that it can also use Whereabouts. So macvlan now has two assemblies instead of one.macvlan previously was configured entirely via YAML. Now it can also be configured via mixed YAML and JSON objects.
So this adds 1 assembly for advanced macvlan to account for this.