Skip to content

Added hostnetwork to the ways to get traffic in #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

knobunc
Copy link
Contributor

@knobunc knobunc commented Jun 23, 2017

We covered a bunch of ways to get traffic in to your pods, but I
realized we omitted hostnetwork. This fixes that omission.

This can go into any version that has the file. But I'm fine if it just goes into 3.6 and 3.7.

We covered a bunch of ways to get traffic in to your pods, but I
realized we ommitted hostnetwork.  This fixes that ommission.
@knobunc knobunc requested review from bfallonf and pecameron June 23, 2017 12:58
@bfallonf
Copy link

@pecameron Do you have any thoughts on this? Any reason why I shouldn't merge it?

@bfallonf
Copy link

@pecameron any chance for an eye on this? Sorry, it's been a while.

@knobunc knobunc self-assigned this Sep 13, 2017
@ncbaratta ncbaratta added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 9, 2017
Copy link

@pecameron pecameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2018
@kalexand-rh
Copy link
Contributor

@bfallonf, is this good to merge?

@vikram-redhat
Copy link
Contributor

@bfallonf bump

@vikram-redhat
Copy link
Contributor

@ahardin-rh - can you PTAL? As far as I know, this is still relevant.

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-3.11

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #12656

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-3.10

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #12657

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-3.9

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #12658

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-3.7

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #12659

In response to this:

/cherrypick enterprise-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-3.6

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #12660

In response to this:

/cherrypick enterprise-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants