TELCODOCS-1512: Adding content for shared CPUs in performance profile - WIP #68393

rohennes · 2023-11-24T15:14:24Z

TELCODOCS-1512: New feature allows you to define shared CPUs in the performance profile. You can then assign lightweight workload tasks to these shared CPUs to ensure core workload tasks can maximize isolated CPUs.

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/TELCODOCS-1512

Link to docs preview:
https://68393--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-shared-cpu-for-workloads

QE review:

QE has approved this change.

Additional information:

openshift-ci-robot · 2023-11-24T15:14:28Z

@rohennes: This pull request references TELCODOCS-1512 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

TELCODOCS-1512: New feature allows you to define shared CPUs in the performance profile. You can then assign lightweight workload tasks to these shared CPUs to ensure core workload tasks can maximize isolated CPUs.

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/TELCODOCS-1512

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ocpdocs-previewbot · 2023-11-24T15:21:31Z

🤖 Wed Mar 06 11:00:49 - Prow CI generated the docs preview:
https://68393--ocpdocs-pr.netlify.app

openshift-ci-robot · 2023-11-30T14:01:46Z

@rohennes: This pull request references TELCODOCS-1512 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

TELCODOCS-1512: New feature allows you to define shared CPUs in the performance profile. You can then assign lightweight workload tasks to these shared CPUs to ensure core workload tasks can maximize isolated CPUs.

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/TELCODOCS-1512

Link to docs preview:
https://68393--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-shared-cpu-for-workloads

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Tal-or

Did initial pass.

We should have another section for how this feature should work in cgroup version2 when CPU load-balancing disabled, but we would probably need that only to 4.16

modules/configuring-a-workload-to-use-shared-cpus.adoc

Tal-or · 2023-12-04T09:46:45Z

modules/configuring-a-workload-to-use-shared-cpus.adoc

+    requests: 
+     cpu: “2” <1>
+     memory: “100m”
+     openshift.io/shared-cpus: ”1” <2>


The resource name has changed to:
workload.openshift.io/enable-shared-cpus

Tal-or · 2023-12-04T09:50:13Z

modules/configuring-a-workload-to-use-shared-cpus.adoc

+[id="configuring-a-workload-to-use-shared-cpus_{context}"]
+= Configuring a workload to use shared CPUs
+
+You can pin lightweight workload tasks to shared CPUs to improve CPU resource efficiency. When you enable shared CPUs on a node, containers deployed on the node feature the `OPENSHIFT_SHARED_CPUS` environment variable, which specifies the ID of the shared CPUs.


We added another environment variable: OPENSHIFT_ISOLATED_CPUS that specifies the isolated cpus as well and make it easier for the user to distinguished between shared and non shared cpus

modules/configuring-a-workload-to-use-shared-cpus.adoc

rohennes · 2023-12-06T14:50:22Z

modules/configuring-shared-cpus-for-a-workload.adoc

+  nodeSelector:
+    node-role.kubernetes.io/performance: "test" <3>
+----
+<1> Define the shared CPU cores. The number of shared cores must be less than the number of reserved cores.


@Tal-or is this correct: "The number of shared cores must be less than the number of reserved cores."

Should it be "less than or equal to"? So you can specify 2 shared cores and 2 reserved cores, for example?

I don't recall such a constrain, could you please refer me to the original quote from which this constrain was taken?

Sure, it's from this slide: https://docs.google.com/presentation/d/1duzJ3kVuYv4DZbYFywfHCVqIwS2dAYb9WmzOIB0gNI8/edit#slide=id.g2161b900cf2_0_1586
Maximum value: There’s no hard limit as long as it smaller than spec.cpu.reserved

this is wrong and I don't even remember why I wrote it :)
Anyway I fixed it.
There's no hard limit

openshift-ci · 2024-04-12T15:07:38Z

@rohennes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Tal-or · 2024-04-18T13:53:26Z

/lgtm
/hold
since the PR is still WIP
feel free to unhold when ready

openshift-bot · 2024-07-18T01:01:12Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

rohennes · 2024-07-18T13:39:33Z

/lifecycle frozen

openshift-ci · 2024-07-18T13:39:36Z

@rohennes: The lifecycle/frozen label cannot be applied to Pull Requests.

Details

In response to this:

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2024-08-18T00:30:39Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

Tal-or · 2024-08-18T09:12:30Z

/remove-lifecycle rotten

openshift-bot · 2024-11-17T01:00:48Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

Tal-or · 2024-11-20T14:38:12Z

/remove-lifecycle rotten

openshift-bot · 2024-12-21T00:30:12Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

rohennes · 2024-12-21T19:05:13Z

/remove-lifecycle rotten

openshift-bot · 2025-03-22T01:00:49Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

rohennes · 2025-03-24T10:17:04Z

/remove-lifecycle rotten

openshift-bot · 2025-04-24T00:30:31Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2025-05-24T08:00:18Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2025-05-24T08:00:35Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 24, 2023

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 24, 2023

rohennes force-pushed the TELCODOCS-1512 branch from 8b64ecd to 34f2c6d Compare November 24, 2023 15:19

openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2023

rohennes force-pushed the TELCODOCS-1512 branch from 34f2c6d to b7cae3f Compare November 28, 2023 14:22

openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2023

rohennes force-pushed the TELCODOCS-1512 branch 2 times, most recently from f93e442 to 0775884 Compare November 28, 2023 17:09

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2023

rohennes force-pushed the TELCODOCS-1512 branch 3 times, most recently from 8d62037 to bc84855 Compare November 30, 2023 13:34

rohennes changed the title ~~TELCODOCS-1512: Adding content for shared CPUS in performance profile~~ TELCODOCS-1512: Adding content for shared CPUs in performance profile - WIP Nov 30, 2023

rohennes force-pushed the TELCODOCS-1512 branch 3 times, most recently from 34f499d to 8eb3d0b Compare November 30, 2023 16:19

Tal-or reviewed Dec 4, 2023

View reviewed changes

modules/configuring-a-workload-to-use-shared-cpus.adoc Show resolved Hide resolved

rohennes force-pushed the TELCODOCS-1512 branch 3 times, most recently from 5858965 to 318bb4d Compare December 6, 2023 14:33

rohennes commented Dec 6, 2023

View reviewed changes

rohennes force-pushed the TELCODOCS-1512 branch 2 times, most recently from a3f77b0 to e41194a Compare December 6, 2023 15:25

openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Apr 18, 2024

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 18, 2024

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 18, 2024

openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 18, 2024

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2024

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 21, 2024

openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 21, 2024

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 22, 2025

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 24, 2025

openshift-ci bot closed this May 24, 2025

TELCODOCS-1512: Adding content for shared CPUs in performance profile - WIP #68393

TELCODOCS-1512: Adding content for shared CPUs in performance profile - WIP #68393

Uh oh!

Conversation

rohennes commented Nov 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 24, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Nov 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 30, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tal-or left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Tal-or Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

Tal-or Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rohennes Dec 6, 2023

Choose a reason for hiding this comment

Uh oh!

Tal-or Dec 11, 2023

Choose a reason for hiding this comment

Uh oh!

rohennes Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

Tal-or Jan 10, 2024

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Apr 12, 2024

Uh oh!

Tal-or commented Apr 18, 2024

Uh oh!

openshift-bot commented Jul 18, 2024

Uh oh!

rohennes commented Jul 18, 2024

Uh oh!

openshift-ci bot commented Jul 18, 2024

Uh oh!

openshift-bot commented Aug 18, 2024

Uh oh!

Tal-or commented Aug 18, 2024

Uh oh!

openshift-bot commented Nov 17, 2024

Uh oh!

Tal-or commented Nov 20, 2024

Uh oh!

openshift-bot commented Dec 21, 2024

Uh oh!

rohennes commented Dec 21, 2024

Uh oh!

openshift-bot commented Mar 22, 2025

Uh oh!

rohennes commented Mar 24, 2025

Uh oh!

openshift-bot commented Apr 24, 2025

Uh oh!

openshift-bot commented May 24, 2025

Uh oh!

openshift-ci bot commented May 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rohennes commented Nov 24, 2023 •

edited

Loading

openshift-ci-robot commented Nov 24, 2023 •

edited by openshift-ci bot

Loading

ocpdocs-previewbot commented Nov 24, 2023 •

edited

Loading

openshift-ci-robot commented Nov 30, 2023 •

edited by openshift-ci bot

Loading