Skip to content

OCPBUGS-35217: Fix incorrect example in Release Notes #77867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: pipelines-docs-1.14
Choose a base branch
from

Conversation

simonkrenger
Copy link

@simonkrenger simonkrenger commented Jun 21, 2024

The field originally described does not work as expected. This commit adds the missing data field in the example.

Version(s): pipelines-docs-1.14

Issue: https://issues.redhat.com/browse/OCPBUGS-35217

Link to docs preview: -

QE review:

  • QE has approved this change.

Additional information:

In the Release notes for Red Hat OpenShift Pipelines General Availability 1.14 there is the following section (https://docs.openshift.com/pipelines/1.14/about/op-release-notes.html#new-features-1-14_op-release-notes):

With this update, you can define default resource requirements for containers and init-containers in pods that OpenShift Pipelines creates when executing task runs. Use the pipeline.options.configMaps.config-defaults.default-container-resource-requirements spec in the TektonConfig CR to set these requirements. You can set the default values for all containers and also for particular containers by name or by prefix, such as sidecar-*.

However the field described does not work as expected. When trying to use oc patch to add content to such a field the user will get an error like this:

Error from server (BadRequest): admission webhook "webhook.operator.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "default-container-resource-requirements"

This commit fixes that issue.

The field originally described does not work as expected. This commit
adds the missing `data` field in the example.
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 21, 2024
@openshift-ci-robot
Copy link

@simonkrenger: This pull request references Jira Issue OCPBUGS-35217, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-35217 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The field originally described does not work as expected. This commit adds the missing data field in the example.

Version(s): OpenShift Pipelines 1.14

Issue: https://issues.redhat.com/browse/OCPBUGS-35217

Link to docs preview: -

QE review:

  • QE has approved this change.

Additional information:

In the Release notes for Red Hat OpenShift Pipelines General Availability 1.14 there is the following section (https://docs.openshift.com/pipelines/1.14/about/op-release-notes.html#new-features-1-14_op-release-notes):

With this update, you can define default resource requirements for containers and init-containers in pods that OpenShift Pipelines creates when executing task runs. Use the pipeline.options.configMaps.config-defaults.default-container-resource-requirements spec in the TektonConfig CR to set these requirements. You can set the default values for all containers and also for particular containers by name or by prefix, such as sidecar-*.

However the field described does not work as expected. When trying to use oc patch to add content to such a field the user will get an error like this:

Error from server (BadRequest): admission webhook "webhook.operator.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "default-container-resource-requirements"

This commit fixes that issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2024
@ocpdocs-previewbot
Copy link

🤖 Fri Jun 21 13:59:18 - Prow CI generated the docs preview:

https://77867--ocpdocs-pr.netlify.app/openshift-pipelines/latest/about/op-release-notes.html

Copy link

openshift-ci bot commented Jun 21, 2024

@simonkrenger: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kalexand-rh kalexand-rh requested a review from mramendi June 24, 2024 17:50
@simonkrenger
Copy link
Author

PTAL @mramendi

@simonkrenger
Copy link
Author

PTAL @mramendi Thanks

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 8, 2024
@mramendi
Copy link
Contributor

mramendi commented Dec 8, 2024

lgtm

Copy link
Contributor

@mramendi mramendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - please reach me on slack with such issues as I failed to notice. Also please change the "version" to "pipelines-docs-1.14" as it needs to be merged there.

@mramendi
Copy link
Contributor

mramendi commented Dec 8, 2024

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Dec 8, 2024
@openshift-ci-robot
Copy link

@simonkrenger: This pull request references Jira Issue OCPBUGS-35217, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-35217 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

The field originally described does not work as expected. This commit adds the missing data field in the example.

Version(s): pipelines-docs-1.14

Issue: https://issues.redhat.com/browse/OCPBUGS-35217

Link to docs preview: -

QE review:

  • QE has approved this change.

Additional information:

In the Release notes for Red Hat OpenShift Pipelines General Availability 1.14 there is the following section (https://docs.openshift.com/pipelines/1.14/about/op-release-notes.html#new-features-1-14_op-release-notes):

With this update, you can define default resource requirements for containers and init-containers in pods that OpenShift Pipelines creates when executing task runs. Use the pipeline.options.configMaps.config-defaults.default-container-resource-requirements spec in the TektonConfig CR to set these requirements. You can set the default values for all containers and also for particular containers by name or by prefix, such as sidecar-*.

However the field described does not work as expected. When trying to use oc patch to add content to such a field the user will get an error like this:

Error from server (BadRequest): admission webhook "webhook.operator.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "default-container-resource-requirements"

This commit fixes that issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kalexand-rh kalexand-rh changed the title OCPBUGS-35217: Fix incorrect example in Release Notes OCPBUGS#5217: Fix incorrect example in Release Notes Dec 9, 2024
@openshift-ci-robot openshift-ci-robot removed jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 9, 2024
@openshift-ci-robot
Copy link

@simonkrenger: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

The field originally described does not work as expected. This commit adds the missing data field in the example.

Version(s): pipelines-docs-1.14

Issue: https://issues.redhat.com/browse/OCPBUGS-35217

Link to docs preview: -

QE review:

  • QE has approved this change.

Additional information:

In the Release notes for Red Hat OpenShift Pipelines General Availability 1.14 there is the following section (https://docs.openshift.com/pipelines/1.14/about/op-release-notes.html#new-features-1-14_op-release-notes):

With this update, you can define default resource requirements for containers and init-containers in pods that OpenShift Pipelines creates when executing task runs. Use the pipeline.options.configMaps.config-defaults.default-container-resource-requirements spec in the TektonConfig CR to set these requirements. You can set the default values for all containers and also for particular containers by name or by prefix, such as sidecar-*.

However the field described does not work as expected. When trying to use oc patch to add content to such a field the user will get an error like this:

Error from server (BadRequest): admission webhook "webhook.operator.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "default-container-resource-requirements"

This commit fixes that issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kalexand-rh
Copy link
Contributor

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 9, 2024
@simonkrenger simonkrenger changed the title OCPBUGS#5217: Fix incorrect example in Release Notes OCPBUGS-35217: Fix incorrect example in Release Notes Dec 9, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 9, 2024
@openshift-ci-robot
Copy link

@simonkrenger: This pull request references Jira Issue OCPBUGS-35217, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-35217 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

The field originally described does not work as expected. This commit adds the missing data field in the example.

Version(s): pipelines-docs-1.14

Issue: https://issues.redhat.com/browse/OCPBUGS-35217

Link to docs preview: -

QE review:

  • QE has approved this change.

Additional information:

In the Release notes for Red Hat OpenShift Pipelines General Availability 1.14 there is the following section (https://docs.openshift.com/pipelines/1.14/about/op-release-notes.html#new-features-1-14_op-release-notes):

With this update, you can define default resource requirements for containers and init-containers in pods that OpenShift Pipelines creates when executing task runs. Use the pipeline.options.configMaps.config-defaults.default-container-resource-requirements spec in the TektonConfig CR to set these requirements. You can set the default values for all containers and also for particular containers by name or by prefix, such as sidecar-*.

However the field described does not work as expected. When trying to use oc patch to add content to such a field the user will get an error like this:

Error from server (BadRequest): admission webhook "webhook.operator.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "default-container-resource-requirements"

This commit fixes that issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 11, 2025
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants