-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS-35217: Fix incorrect example in Release Notes #77867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pipelines-docs-1.14
Are you sure you want to change the base?
OCPBUGS-35217: Fix incorrect example in Release Notes #77867
Conversation
The field originally described does not work as expected. This commit adds the missing `data` field in the example.
@simonkrenger: This pull request references Jira Issue OCPBUGS-35217, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Fri Jun 21 13:59:18 - Prow CI generated the docs preview: https://77867--ocpdocs-pr.netlify.app/openshift-pipelines/latest/about/op-release-notes.html |
@simonkrenger: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PTAL @mramendi |
PTAL @mramendi Thanks |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - please reach me on slack with such issues as I failed to notice. Also please change the "version" to "pipelines-docs-1.14" as it needs to be merged there.
/label peer-review-done |
@simonkrenger: This pull request references Jira Issue OCPBUGS-35217, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@simonkrenger: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/remove-lifecycle stale |
@simonkrenger: This pull request references Jira Issue OCPBUGS-35217, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
The field originally described does not work as expected. This commit adds the missing
data
field in the example.Version(s): pipelines-docs-1.14
Issue: https://issues.redhat.com/browse/OCPBUGS-35217
Link to docs preview: -
QE review:
Additional information:
In the Release notes for Red Hat OpenShift Pipelines General Availability 1.14 there is the following section (https://docs.openshift.com/pipelines/1.14/about/op-release-notes.html#new-features-1-14_op-release-notes):
However the field described does not work as expected. When trying to use
oc patch
to add content to such a field the user will get an error like this:This commit fixes that issue.