-
Notifications
You must be signed in to change notification settings - Fork 1.8k
One backup CR per location #78734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One backup CR per location #78734
Conversation
|
Please confirm/deny if a single backup can only have offsite OR snapshot. I believe there is a recent change where that is no longer true as of OADP 1.4 |
|
@kaovilai Depends on the configuration of backup CR whether to move the snapshot off-cluster or not, volume policy only helps specify snapshot as an action. |
|
|
||
| * The `Backup` CR creates backup files for Kubernetes resources and internal images on S3 object storage. | ||
| * A `Backup` CR creates backup files for Kubernetes resources and internal images on S3 object storage. | ||
| * You need to create one `Backup` CR per storage location. For example, to perform a backup that includes a backup of a local snapshot and a backup of an offsite location, you need to create two `Backup` CRs, one for each location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need add this correlation of backup and backupstoragelocation. You can have multiple backup CRs using the same BSL or they can also use different BSLs
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
/remove-lifecycle stale |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
2936747 to
456200a
Compare
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
/remove-lifecycle stale |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@RichardHoch: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@RichardHoch: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
OADP 1.4.x ; OCP 4.12+
Resolves https://issues.redhat.com/browse/OADP-1791 by adding a bulleted list item that explains that a separate
BackupCR is needed per location.Preview: https://78734--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/backing_up_and_restoring/backing-up-applications.html [small edit to initial sentence; added 2nd bullet in list]