Added oc adm drain options for 3.9 #7881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
pravisankar
suggested changes
Feb 21, 2018
admin_guide/manage_nodes.adoc
Outdated
| @@ -241,7 +241,7 @@ controller] can be evacuated; the replication controllers create new pods on | |||
| other nodes and remove the existing pods from the specified node(s). Bare pods, | |||
| meaning those not backed by a replication controller, are unaffected by default. | |||
|
|
|||
| To evacuate one or more nodes: | |||
| To evacuate all or selected pods on one or more nodes: | |||
|
|
|||
| ---- | |||
| $ oc adm drain <node1> <node2> | |||
There was a problem hiding this comment.
We are saying 'evacuate all or selected pods' but we are not telling how to do that using a command.
We should talk about --pod-selector here and show that as optional param to the command.
$ oc adm drain <node1> <node2> [--pod-selector=<pod_selector>]
I've assumed '[ ]' is used for optional flags if that is not the case use what ever convention is used in other places.
admin_guide/manage_nodes.adoc
Outdated
| can use the `--selector=<node_selector>` option to evacuate pods on selected | ||
| nodes. | ||
|
|
||
| You can also use `--pod-selector=<pod>` to filter pods on the node. |
There was a problem hiding this comment.
This can be skipped if we have already mentioned this option before.
ahardin-rh
force-pushed
the
oc-adm-drain-39
branch
from
d3ea8c6 to
ce14a8a
Compare
|
@pravisankar Thanks! I made some edits. Please let me know if more changes are necessary. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added per discussion in #5709 (comment)
@pravisankar PTAL