Skip to content

Added oc adm drain options for 3.9 #7881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

ahardin-rh
Copy link
Contributor

Added per discussion in #5709 (comment)

@pravisankar PTAL

@ahardin-rh ahardin-rh added this to the Future Release milestone Feb 21, 2018
@ahardin-rh ahardin-rh self-assigned this Feb 21, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 21, 2018
@@ -241,7 +241,7 @@ controller] can be evacuated; the replication controllers create new pods on
other nodes and remove the existing pods from the specified node(s). Bare pods,
meaning those not backed by a replication controller, are unaffected by default.

To evacuate one or more nodes:
To evacuate all or selected pods on one or more nodes:

----
$ oc adm drain <node1> <node2>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are saying 'evacuate all or selected pods' but we are not telling how to do that using a command.
We should talk about --pod-selector here and show that as optional param to the command.

 $ oc adm drain <node1> <node2> [--pod-selector=<pod_selector>]

I've assumed '[ ]' is used for optional flags if that is not the case use what ever convention is used in other places.

can use the `--selector=<node_selector>` option to evacuate pods on selected
nodes.

You can also use `--pod-selector=<pod>` to filter pods on the node.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be skipped if we have already mentioned this option before.

@ahardin-rh
Copy link
Contributor Author

@pravisankar Thanks! I made some edits. Please let me know if more changes are necessary. Thanks again!

Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.9 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants