Skip to content

OSDOCS#11456: Configuring Azure account improvements #79423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2024
Merged

OSDOCS#11456: Configuring Azure account improvements #79423

merged 1 commit into from
Dec 17, 2024
+79 −117

Conversation

snarayan-redhat
Copy link
Contributor

@snarayan-redhat snarayan-redhat commented Jul 25, 2024 •
edited
Loading

Sorry, something went wrong.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 25, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 25, 2024 •
edited
Loading

🤖 Tue Dec 17 07:02:47 - Prow CI generated the docs preview:

https://79423--ocpdocs-pr.netlify.app/
https://79423--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_azure/installing-azure-account.html
https://79423--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_azure/ipi/installing-azure-preparing-ipi.html
https://79423--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_azure_stack_hub/installing-azure-stack-hub-account.html
https://79423--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_azure_stack_hub/upi/installing-azure-stack-hub-user-infra.html
https://79423--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_azure/upi/installing-azure-user-infra.html
https://79423--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_azure/upi/installing-restricted-networks-azure-user-provisioned.html

@snarayan-redhat snarayan-redhat force-pushed the OSDOCS-11456_configuringazureacct branch from 93f950c to 635bbf6 Compare July 25, 2024 11:19
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2024
@snarayan-redhat snarayan-redhat force-pushed the OSDOCS-11456_configuringazureacct branch from 635bbf6 to bac8b48 Compare July 25, 2024 12:30
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jul 25, 2024
View reviewed changes
@snarayan-redhat snarayan-redhat force-pushed the OSDOCS-11456_configuringazureacct branch 2 times, most recently from 7f787d2 to 21f9c06 Compare July 26, 2024 09:38
@snarayan-redhat
Copy link
Contributor Author

/retest

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 27, 2024
@snarayan-redhat snarayan-redhat force-pushed the OSDOCS-11456_configuringazureacct branch 2 times, most recently from 04e7fd2 to db9a294 Compare November 4, 2024 10:35
@snarayan-redhat snarayan-redhat removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2024
@snarayan-redhat snarayan-redhat force-pushed the OSDOCS-11456_configuringazureacct branch 2 times, most recently from 39ccd33 to 1e395c4 Compare November 26, 2024 08:18
jinyunma
jinyunma reviewed Nov 28, 2024
View reviewed changes
jinyunma
jinyunma reviewed Nov 28, 2024
View reviewed changes
@snarayan-redhat snarayan-redhat force-pushed the OSDOCS-11456_configuringazureacct branch 2 times, most recently from 1447e28 to 71b5f61 Compare December 4, 2024 06:37
@snarayan-redhat snarayan-redhat force-pushed the OSDOCS-11456_configuringazureacct branch from 71b5f61 to 3aab3bd Compare December 12, 2024 06:13
@snarayan-redhat
Copy link
Contributor Author

@jinyunma Can you take another look? I have implemented all of your suggestions.

@jinyunma
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
@snarayan-redhat snarayan-redhat added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 16, 2024
@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 16, 2024
GroceryBoyJr
GroceryBoyJr reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few small nits, otherwise, LGTM!

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Dec 16, 2024
@snarayan-redhat
Copy link
Contributor Author

Only a few small nits, otherwise, LGTM!

Thanks for your review, @GroceryBoyJr !

@snarayan-redhat snarayan-redhat force-pushed the OSDOCS-11456_configuringazureacct branch from 3aab3bd to e77eae0 Compare December 17, 2024 06:49
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 17, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 17, 2024

@snarayan-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@snarayan-redhat snarayan-redhat added this to the Planned for 4.18 GA milestone Dec 17, 2024
@snarayan-redhat snarayan-redhat merged commit 72da6af into openshift:main Dec 17, 2024
2 checks passed
@snarayan-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.18

@openshift-cherrypick-robot
Copy link

@snarayan-redhat: new pull request created: #86344

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinyunma jinyunma

@GroceryBoyJr GroceryBoyJr

@ocpdocs-vale-bot ocpdocs-vale-bot

Assignees

@jinyunma jinyunma

Labels
branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.18 GA
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@snarayan-redhat @ocpdocs-previewbot @openshift-bot @jinyunma @GroceryBoyJr @openshift-cherrypick-robot @ocpdocs-vale-bot