Skip to content

OSDOCS-11732: Add dummy device as additional network #81643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSDOCS-11732: Add dummy device as additional network #81643

wants to merge 1 commit into from

Conversation

jab-rh
Copy link
Contributor

@jab-rh jab-rh commented Sep 11, 2024 •
edited
Loading

Version(s): 4.17+

Issue:

Link to docs preview:

Configuration for a dummy device additional network

QE review:

  • QE has approved this change.

Additional information:

@jab-rh jab-rh added this to the Planned for 4.17 GA milestone Sep 11, 2024
@jab-rh jab-rh self-assigned this Sep 11, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 11, 2024 •
edited by openshift-ci bot
Loading

@jab-rh: This pull request references OSDOCS-11732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 11, 2024 •
edited by openshift-ci bot
Loading

@jab-rh: This pull request references OSDOCS-11732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 11, 2024 •
edited
Loading

🤖 Fri May 02 19:31:25 - Prow CI generated the docs preview:

https://81643--ocpdocs-pr.netlify.app/

@jab-rh
Copy link
Contributor Author

jab-rh commented Sep 12, 2024

@dougbtv, I've added the dummy device to the additional networks configuration page. What do you think? Thanks!

dougbtv
dougbtv reviewed Sep 13, 2024
View reviewed changes
modules/nw-multus-dummy-device-object.adoc Outdated

|`name`
|`string`
|The value for the `name` parameter you provided previously for the CNO configuration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is arbitrary but I think the recommended value is useful (as it may appear this way in logging), nicely done.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 16, 2024 •
edited by openshift-ci bot
Loading

@jab-rh: This pull request references OSDOCS-11732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to this:

Version(s): 4.17+

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 16, 2024 •
edited by openshift-ci bot
Loading

@jab-rh: This pull request references OSDOCS-11732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to this:

Version(s): 4.17+

Issue:

Link to docs preview:

Configuration for a dummy device additional network

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jab-rh jab-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 17, 2024
@agantony
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 18, 2024
agantony
agantony reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@agantony agantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions for your consideration; overall lgtm!

modules/nw-multus-dummy-device-object.adoc
|====

[id="nw-multus-dummy-device-config-example_{context}"]
== dummy configuration example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
== dummy configuration example
== Dummy configuration example

@agantony
Copy link
Contributor

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 18, 2024
@kalexand-rh
Copy link
Contributor

The branch/enterprise-4.18 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.17. And any PR going into main must also target the latest version branch (enterprise-4.18).

If the update in your PR does NOT apply to version 4.18 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@weliang1
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 11, 2025
@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.19 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.18. And any PR going into main must also target the latest version branch (enterprise-4.19).

If the update in your PR does NOT apply to version 4.19 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 27, 2025
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Apr 26, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 26, 2025

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jab-rh jab-rh reopened this May 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 2, 2025 •
edited by openshift-ci bot
Loading

@jab-rh: This pull request references OSDOCS-11732 which is a valid jira issue.

In response to this:

Version(s): 4.17+

Issue:

Link to docs preview:

Configuration for a dummy device additional network

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jab-rh jab-rh removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 2, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 2, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 2, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 2, 2025

@jab-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agantony agantony agantony left review comments

@dougbtv dougbtv dougbtv requested changes

Assignees

@weliang1 weliang1

@jab-rh jab-rh

Labels
branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
9 participants
@jab-rh @openshift-ci-robot @ocpdocs-previewbot @agantony @kalexand-rh @weliang1 @openshift-bot @bergerhoffer @dougbtv