Skip to content

OCPBUGS-20159: Document how to enable LSO metrics after installation #83646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-20159: Document how to enable LSO metrics after installation #83646

wants to merge 1 commit into from

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Oct 16, 2024 •
edited
Loading

@openshift-ci openshift-ci bot requested a review from chao007 October 16, 2024 17:43
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 16, 2024
@openshift-ci-robot
Copy link

@dobsonj: This pull request references Jira Issue OCPBUGS-20159, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

4.14+

Issue:

https://issues.redhat.com/browse/OCPBUGS-20159

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

/cc @openshift/storage @chao007 @lpettyjo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from lpettyjo October 16, 2024 17:43
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 16, 2024

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Version(s):

4.14+

Issue:

https://issues.redhat.com/browse/OCPBUGS-20159

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

/cc @openshift/storage @chao007 @lpettyjo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 16, 2024
@openshift-ci-robot
Copy link

@dobsonj: This pull request references Jira Issue OCPBUGS-20159, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

Version(s):

4.13+

Issue:

https://issues.redhat.com/browse/OCPBUGS-20159

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

/cc @openshift/storage @chao007 @lpettyjo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 16, 2024 •
edited
Loading

🤖 Mon Jan 06 23:38:00 - Prow CI generated the docs preview:

https://83646--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage/persistent_storage_local/persistent-storage-local.html

@jsafrane
Copy link
Contributor

jsafrane commented Jan 3, 2025

lgtm

@lpettyjo lpettyjo added this to the Continuous Release milestone Jan 6, 2025
@lpettyjo lpettyjo added peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 6, 2025
lpettyjo
lpettyjo reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 6, 2025
@dobsonj
Copy link
Member Author

dobsonj commented Jan 6, 2025

Updated, thanks!

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 6, 2025

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lpettyjo
Copy link
Contributor

lpettyjo commented Jan 7, 2025

LGTM!

chao007
chao007 reviewed Jan 17, 2025
View reviewed changes
modules/persistent-storage-local-metrics.adoc

* Enable support for monitoring when installing the Local Storage Operator.
* When installing the Local Storage Operator from _OperatorHub_ in the web console, select the _Enable Operator recommended cluster monitoring on this Namespace_ checkbox.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add this pic is better?
Screenshot 2025-01-17 at 11 11 01

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.19 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.18. And any PR going into main must also target the latest version branch (enterprise-4.19).

If the update in your PR does NOT apply to version 4.19 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chao007 chao007 chao007 left review comments

@lpettyjo lpettyjo lpettyjo left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@dobsonj @openshift-ci-robot @ocpdocs-previewbot @jsafrane @lpettyjo @bergerhoffer @chao007