-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS#11144:Secret Store TP->GA #84311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lpettyjo LGTM. Don't forget to update the Table 18. Storage Technology Preview tracker in the release notes. |
772f448
to
0b14c36
Compare
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty!
/lgtm |
In "Secrets store providers" section, we mention "The following secrets store providers are available for use with the Secrets Store CSI Driver Operator:" |
@nkpng2k is the PM responsible for provider's integration. He will provide the wording guidelines |
@gcharot nothing is technically supported since it's only released as technology preview. We specifically don't say anything about "supported" for that reason. In our case it really just means that we've tested them that they work. |
Apologies ignore me - I'm still in last release's mode before we went GA 🤦♀️ |
yes that was fine for TP but it goes GA in 4.18 |
I proposed a similar change for cert-manager:Supported issuer types:
The tests performed can be found here: [From Polarion] Due to provider limitations such as licensing or access to partner infrastructure, Red Hat cannot test all factors associated with proper functionality of the issuers. Red Hat support for these 3rd party softwares can be found here <insert link to 3rd party software support statement from red hat> |
Looks good @nkpng2k by 3rd party support statement do you mean https://access.redhat.com/third-party-software-support ? |
agree with @gcharot wrt to polarion... was a suggestion that maybe we add an actual table. Dates versions etc. although, the likelihood that these tests were run on OCP 4.15/4.16 is very high.
yes |
LGTM |
@bergerhoffer Hey Andrea, are you going to make these changes are do you want me to make them in this PR? |
@lpettyjo I can take care of that update. I've opened https://issues.redhat.com/browse/OSDOCS-12832 to track it. |
LGTM assuming we're covering the provider's wording in another PR |
/cherrypick enterprise-4.18 |
@lpettyjo: new pull request created: #86782 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.18+
Issue: https://issues.redhat.com/browse/OSDOCS-11144
Link to docs preview: https://84311--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-secrets-store.html
QE review:
Additional information:
PTAL: @dobsonj @wsun1 @gcharot