Skip to content

OSDOCS#11144:Secret Store TP->GA #84311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Oct 31, 2024

Sorry, something went wrong.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2024
@lpettyjo lpettyjo added peer-review-needed Signifies that the peer review team needs to review this PR and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2024
@lpettyjo lpettyjo added this to the Planned for 4.18 GA milestone Oct 31, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 31, 2024

@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 31, 2024
@mburke5678
Copy link
Contributor

@lpettyjo LGTM. Don't forget to update the Table 18. Storage Technology Preview tracker in the release notes.

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 31, 2024
Copy link

openshift-ci bot commented Nov 7, 2024

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lpettyjo lpettyjo requested a review from bergerhoffer November 7, 2024 19:31
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty!

@dobsonj
Copy link
Member

dobsonj commented Nov 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
@gcharot
Copy link

gcharot commented Nov 13, 2024

In "Secrets store providers" section, we mention "The following secrets store providers are available for use with the Secrets Store CSI Driver Operator:"
What do we mean by "are available"? Are those actually certified/supported?

@gcharot
Copy link

gcharot commented Nov 13, 2024

@nkpng2k is the PM responsible for provider's integration. He will provide the wording guidelines

@bergerhoffer
Copy link
Contributor

In "Secrets store providers" section, we mention "The following secrets store providers are available for use with the Secrets Store CSI Driver Operator:" What do we mean by "are available"? Are those actually certified/supported?

@gcharot nothing is technically supported since it's only released as technology preview. We specifically don't say anything about "supported" for that reason. In our case it really just means that we've tested them that they work.

@bergerhoffer
Copy link
Contributor

In "Secrets store providers" section, we mention "The following secrets store providers are available for use with the Secrets Store CSI Driver Operator:" What do we mean by "are available"? Are those actually certified/supported?

@gcharot nothing is technically supported since it's only released as technology preview. We specifically don't say anything about "supported" for that reason. In our case it really just means that we've tested them that they work.

Apologies ignore me - I'm still in last release's mode before we went GA 🤦‍♀️

@gcharot
Copy link

gcharot commented Nov 13, 2024

yes that was fine for TP but it goes GA in 4.18

@nkpng2k
Copy link

nkpng2k commented Nov 18, 2024

I proposed a similar change for cert-manager:

Supported issuer types:
The cert-manager operator for Red Hat OpenShift has been tested with the following issuer types:

The tests performed can be found here:

[From Polarion]

Due to provider limitations such as licensing or access to partner infrastructure, Red Hat cannot test all factors associated with proper functionality of the issuers.

Red Hat support for these 3rd party softwares can be found here <insert link to 3rd party software support statement from red hat>

@gcharot
Copy link

gcharot commented Nov 18, 2024

Looks good @nkpng2k
I don't think we should link to polarion though

by 3rd party support statement do you mean https://access.redhat.com/third-party-software-support ?

@nkpng2k
Copy link

nkpng2k commented Nov 18, 2024

agree with @gcharot wrt to polarion... was a suggestion that maybe we add an actual table. Dates versions etc. although, the likelihood that these tests were run on OCP 4.15/4.16 is very high.

by 3rd party support statement do you mean https://access.redhat.com/third-party-software-support ?

yes

@ropatil010
Copy link

LGTM

@lpettyjo
Copy link
Contributor Author

lpettyjo commented Dec 3, 2024

I proposed a similar change for cert-manager:

Supported issuer types: The cert-manager operator for Red Hat OpenShift has been tested with the following issuer types:

The tests performed can be found here:

[From Polarion]

Due to provider limitations such as licensing or access to partner infrastructure, Red Hat cannot test all factors associated with proper functionality of the issuers.

Red Hat support for these 3rd party softwares can be found here <insert link to 3rd party software support statement from red hat>

@bergerhoffer Hey Andrea, are you going to make these changes are do you want me to make them in this PR?

@bergerhoffer
Copy link
Contributor

@lpettyjo I can take care of that update. I've opened https://issues.redhat.com/browse/OSDOCS-12832 to track it.

@gcharot
Copy link

gcharot commented Dec 4, 2024

LGTM assuming we're covering the provider's wording in another PR

@lpettyjo lpettyjo merged commit 36f4479 into openshift:main Jan 7, 2025
2 checks passed
@lpettyjo
Copy link
Contributor Author

lpettyjo commented Jan 7, 2025

/cherrypick enterprise-4.18

@openshift-cherrypick-robot

@lpettyjo: new pull request created: #86782

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.18 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants