Skip to content

OSDOCS-12183-rework: rework of changes in delete Kustomize manifest resources #84633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2024
Merged

OSDOCS-12183-rework: rework of changes in delete Kustomize manifest resources #84633

merged 1 commit into from
Nov 11, 2024
+40 −24

Conversation

aravipra
Copy link
Contributor

@aravipra aravipra commented Nov 7, 2024 •
edited
Loading

Version(s):
4.18+

Issue:
OSDOCS-12183

Link to docs preview:
Deleting or upgrading Kustomize manifest resources
How Kustomize works with manifests to deploy applications
Additional resources
Additional resources

QE review:

  • NA. Stock text changes. No technical chnages are done.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 7, 2024
This was referenced Nov 7, 2024
Merged
Merged
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 7, 2024 •
edited
Loading

🤖 Fri Nov 08 14:38:42 - Prow CI generated the docs preview:

https://84633--ocpdocs-pr.netlify.app/microshift/latest/microshift_running_apps/microshift-applications.html
https://84633--ocpdocs-pr.netlify.app/microshift/latest/microshift_running_apps/microshift-deleting-resource-manifests.html

@aravipra aravipra changed the title OSDOCS-12183-rework: rework of changes in delete Kustomize manifest resources [WIP] OSDOCS-12183-rework: rework of changes in delete Kustomize manifest resources Nov 7, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@aravipra
Copy link
Contributor Author

aravipra commented Nov 7, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 7, 2024
@skopacz1 skopacz1 added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.18 labels Nov 7, 2024
@skopacz1 skopacz1 added this to the Planned for 4.18 GA milestone Nov 7, 2024
@aravipra aravipra force-pushed the OSDOCS-12183-rework branch from deb5c91 to 5a3143d Compare November 7, 2024 19:15
skopacz1
skopacz1 reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments and some suggestions, otherwise LGTM

@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 7, 2024
@aravipra aravipra force-pushed the OSDOCS-12183-rework branch from 5a3143d to 72723a9 Compare November 8, 2024 14:16
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 8, 2024

@aravipra: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShaunaDiaz ShaunaDiaz changed the title [WIP] OSDOCS-12183-rework: rework of changes in delete Kustomize manifest resources OSDOCS-12183-rework: rework of changes in delete Kustomize manifest resources Nov 11, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2024
@ShaunaDiaz ShaunaDiaz merged commit 0d05d2a into openshift:main Nov 11, 2024
2 checks passed
@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.18

@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #84723

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 11, 2024
Merged
@aravipra
Copy link
Contributor Author

aravipra commented Nov 11, 2024 •
edited
Loading

I had asked Shauna to merge the PR on slack when I was away. Hence the merge review needed label is not added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skopacz1 skopacz1

Assignees
No one assigned
Labels
branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.18 GA
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aravipra @ocpdocs-previewbot @ShaunaDiaz @openshift-cherrypick-robot @skopacz1