TELCODOCS-2064: Docs and RN: CNF-14082 SR-IOV Operator support for Intel C741 Emmitsburg Chipset #84760

ogradyp · 2024-11-11T17:44:37Z

https://issues.redhat.com/browse/TELCODOCS-2064: Docs and RN: CNF-14082 SR-IOV Operator support for Intel C741 Emmitsburg Chipset

Applies to OCP version : 4.18+

Preview: SR-IOV Network Operator config custom resource

Dev review completed by @cgoncalves
Dev review completed by @SchSeba
Peer review completed by @cbippley

Thank you.

openshift-ci-robot · 2024-11-11T17:44:41Z

@ogradyp: This pull request references TELCODOCS-2064 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

…ameter

Version(s):

Issue:

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2024-11-11T18:00:22Z

🤖 Wed Feb 12 09:17:25 - Prow CI generated the docs preview:

https://84760--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/sr-iov-operator/configuring-sriov-operator.html

openshift-ci-robot · 2024-11-12T09:30:38Z

@ogradyp: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

…ameter

Version(s):

Issue:

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cgoncalves

Release note missing?

cgoncalves · 2024-11-12T10:15:08Z

modules/nw-sriov-configuring-operator.adoc

@@ -96,6 +96,10 @@ By default, this field is set to `2`.
 |`boolean`
 |Specifies whether to enable or disable the SR-IOV Network Operator metrics. By default, this field is set to `false`.

+|`spec.featureGates.mellanoxFirmwareReset`
+|`boolean`
+|Specifies whether to reset the firmware in the SR-IOV Network Operator. By default, this field is set to `true`.


Feel free to re-phrase my suggestion:

Suggested change

|Specifies whether to reset the firmware in the SR-IOV Network Operator. By default, this field is set to `true`.

|Specifies whether to reset the firmware on VF changes in the SR-IOV Network Operator. Certain chipsets (e.g., Intel C740 Series) do not completely power off the PCI-E devices, which is required to configure VFs on NVIDIA/Mellanox NICs. By default, this field is set to `false`.

Thanks @cgoncalves for your feedback. I have included, and slightly re-phrased, your suggestion.

cgoncalves · 2024-11-12T10:16:13Z

modules/nw-sriov-configuring-operator.adoc

@@ -96,6 +96,10 @@ By default, this field is set to `2`.
 |`boolean`
 |Specifies whether to enable or disable the SR-IOV Network Operator metrics. By default, this field is set to `false`.

+|`spec.featureGates.mellanoxFirmwareReset`


This is a Tech Preview feature. Can we have a TP note here somehow?

Thanks @cgoncalves for your feedback. I have included the standard Technology Preview text snippet that appears with all Technology Preview features.

ogradyp · 2024-11-13T11:50:46Z

Release note missing?

Thanks @cgoncalves for your feedback. As the Release Note will be specific to the 4.18 stream, it will be included in a separate PR.

cgoncalves · 2024-11-13T12:01:12Z

Thanks @ogradyp for the documentation! LGTM.

Please hold the merge. We're still finalizing the Tech Preview details internally.
/hold

SchSeba

/lgtm

ogradyp · 2024-11-14T15:04:08Z

Thanks @ogradyp for the documentation! LGTM.

Please hold the merge. We're still finalizing the Tech Preview details internally. /hold

Thanks @cgoncalves for your approval. Sure, I will hold the merge. Please let me know as soon as the Tech Preview details are finalized.

openshift-ci-robot · 2024-11-25T16:46:43Z

@ogradyp: This pull request references TELCODOCS-2064 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/TELCODOCS-2064: Docs and RN: CNF-14082 SR-IOV Operator support for Intel C741 Emmitsburg Chipset

Applies to OCP version : 4.18+

Preview: SR-IOV Network Operator config custom resource

Dev review completed by @cgoncalves
Dev review completed by @SchSeba
Peer review completed by @StephenJamesSmith

Thank you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cgoncalves · 2025-02-07T09:34:45Z

/unhold

Good to go from Engineering. Thank you for the patience in waiting this long.

openshift-ci · 2025-02-11T15:47:17Z

New changes are detected. LGTM label has been removed.

ogradyp · 2025-02-11T16:17:23Z

/unhold

Good to go from Engineering. Thank you for the patience in waiting this long.

Thanks @cgoncalves for your update. I will send it for review and merging.

ogradyp · 2025-02-11T16:18:33Z

/label peer-review-needed

cbippley · 2025-02-11T19:10:38Z

/label peer-review-in-progress
/remove-label peer-review-needed

cbippley

One nit, LGTM!

cbippley · 2025-02-11T19:26:31Z

modules/nw-sriov-configuring-operator.adoc

@@ -96,6 +96,13 @@ By default, this field is set to `2`.
 |`boolean`
 |Specifies whether to enable or disable the SR-IOV Network Operator metrics. By default, this field is set to `false`.

+|`spec.featureGates.mellanoxFirmwareReset`
+|`boolean`
+|Specifies whether to reset the firmware on virtual function (VF) changes in the SR-IOV Network Operator. Some chipsets (for example, Intel C740 Series) do not completely power off the PCI-E devices, which is required to configure VFs on NVIDIA/Mellanox NICs. By default, this field is set to `false`.


Suggested change

|Specifies whether to reset the firmware on virtual function (VF) changes in the SR-IOV Network Operator. Some chipsets (for example, Intel C740 Series) do not completely power off the PCI-E devices, which is required to configure VFs on NVIDIA/Mellanox NICs. By default, this field is set to `false`.

|Specifies whether to reset the firmware on virtual function (VF) changes in the SR-IOV Network Operator. Some chipsets, such as the Intel C740 Series, do not completely power off the PCI-E devices, which is required to configure VFs on NVIDIA/Mellanox NICs. By default, this field is set to `false`.

Avoiding parenthesis: https://www.ibm.com/docs/en/ibm-style?topic=punctuation-parentheses
Using "such as" instead of "for example": https://www.ibm.com/docs/en/ibm-style?topic=format-examples

cbippley · 2025-02-11T19:27:10Z

/label peer-review-done
/remove-label peer-review-in-progress

…ameter TELCODOCS-2064: Dev feedback applied TELCODOCS-2064: Technology Preview snippet text added TELCODOCS-2064: Peer review feedback applied

openshift-ci · 2025-02-12T09:18:51Z

@ogradyp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ogradyp · 2025-02-12T09:24:57Z

One nit, LGTM!

Thanks @cbippley for your review and feedback. I have applied your suggestion.

ogradyp · 2025-02-12T09:28:06Z

/label merge-review-needed

openshift-ci-robot · 2025-02-12T09:53:31Z

@ogradyp: This pull request references TELCODOCS-2064 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/TELCODOCS-2064: Docs and RN: CNF-14082 SR-IOV Operator support for Intel C741 Emmitsburg Chipset

Applies to OCP version : 4.18+

Preview: SR-IOV Network Operator config custom resource

Dev review completed by @cgoncalves
Dev review completed by @SchSeba
Peer review completed by @cbippley

Thank you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

xenolinux

LGTM Merging

xenolinux · 2025-02-12T11:37:56Z

/cherrypick enterprise-4.18

openshift-cherrypick-robot · 2025-02-12T11:38:44Z

@xenolinux: new pull request created: #88453

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference label Nov 11, 2024

openshift-ci bot added the size/XS label Nov 11, 2024

ogradyp changed the title ~~TELCODOCS-2064: Added the spec.featureGates.mellanoxFirmwareReset par…~~ Docs and RN: CNF-14082 SR-IOV Operator support for Intel C741 Emmitsburg Chipset Nov 12, 2024

openshift-ci-robot removed the jira/valid-reference label Nov 12, 2024

cgoncalves suggested changes Nov 12, 2024

View reviewed changes

openshift-ci bot added the do-not-merge/hold label Nov 13, 2024

SchSeba approved these changes Nov 14, 2024

View reviewed changes

openshift-ci bot assigned SchSeba Nov 14, 2024

openshift-ci bot added the lgtm label Nov 14, 2024

ogradyp changed the title ~~Docs and RN: CNF-14082 SR-IOV Operator support for Intel C741 Emmitsburg Chipset~~ TELCODOCS-2064: Docs and RN: CNF-14082 SR-IOV Operator support for Intel C741 Emmitsburg Chipset Nov 25, 2024

openshift-ci-robot added the jira/valid-reference label Nov 25, 2024

openshift-ci bot removed the do-not-merge/hold label Feb 7, 2025

ogradyp force-pushed the TELCODOCS-2064 branch from 243f415 to 852f818 Compare February 11, 2025 15:47

openshift-ci bot removed the lgtm label Feb 11, 2025

openshift-ci bot added the peer-review-needed label Feb 11, 2025

openshift-ci bot added peer-review-in-progress and removed peer-review-needed labels Feb 11, 2025

cbippley reviewed Feb 11, 2025

View reviewed changes

openshift-ci bot added peer-review-done and removed peer-review-in-progress labels Feb 11, 2025

TELCODOCS-2064: Added the spec.featureGates.mellanoxFirmwareReset par…

23b11ad

…ameter TELCODOCS-2064: Dev feedback applied TELCODOCS-2064: Technology Preview snippet text added TELCODOCS-2064: Peer review feedback applied

ogradyp force-pushed the TELCODOCS-2064 branch from 852f818 to 23b11ad Compare February 12, 2025 08:59

openshift-ci bot added the merge-review-needed label Feb 12, 2025

xenolinux added merge-review-in-progress and removed merge-review-needed labels Feb 12, 2025

xenolinux reviewed Feb 12, 2025

View reviewed changes

xenolinux added this to the Planned for 4.18 GA milestone Feb 12, 2025

xenolinux added the branch/enterprise-4.18 label Feb 12, 2025

xenolinux merged commit 312dd87 into openshift:main Feb 12, 2025
2 checks passed

xenolinux removed the merge-review-in-progress label Feb 12, 2025

openshift-cherrypick-robot mentioned this pull request Feb 12, 2025

[enterprise-4.18] TELCODOCS-2064: Docs and RN: CNF-14082 SR-IOV Operator support for Intel C741 Emmitsburg Chipset #88453

Merged

	\|Specifies whether to reset the firmware in the SR-IOV Network Operator. By default, this field is set to `true`.
	\|Specifies whether to reset the firmware on VF changes in the SR-IOV Network Operator. Certain chipsets (e.g., Intel C740 Series) do not completely power off the PCI-E devices, which is required to configure VFs on NVIDIA/Mellanox NICs. By default, this field is set to `false`.

TELCODOCS-2064: Docs and RN: CNF-14082 SR-IOV Operator support for Intel C741 Emmitsburg Chipset #84760

TELCODOCS-2064: Docs and RN: CNF-14082 SR-IOV Operator support for Intel C741 Emmitsburg Chipset #84760

Conversation

ogradyp commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 11, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 12, 2024

Uh oh!

cgoncalves left a comment

Choose a reason for hiding this comment

Uh oh!

cgoncalves Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

ogradyp Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

cgoncalves Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

ogradyp Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

ogradyp commented Nov 13, 2024

Uh oh!

cgoncalves commented Nov 13, 2024

Uh oh!

SchSeba left a comment

Choose a reason for hiding this comment

Uh oh!

ogradyp commented Nov 14, 2024

Uh oh!

openshift-ci-robot commented Nov 25, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cgoncalves commented Feb 7, 2025

Uh oh!

openshift-ci bot commented Feb 11, 2025

Uh oh!

ogradyp commented Feb 11, 2025

Uh oh!

ogradyp commented Feb 11, 2025

Uh oh!

cbippley commented Feb 11, 2025

Uh oh!

cbippley left a comment

Choose a reason for hiding this comment

Uh oh!

cbippley Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

cbippley commented Feb 11, 2025

Uh oh!

openshift-ci bot commented Feb 12, 2025

Uh oh!

ogradyp commented Feb 12, 2025

Uh oh!

ogradyp commented Feb 12, 2025

Uh oh!

openshift-ci-robot commented Feb 12, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xenolinux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xenolinux commented Feb 12, 2025

Uh oh!

openshift-cherrypick-robot commented Feb 12, 2025

Uh oh!

ogradyp commented Nov 11, 2024 •

edited

Loading

openshift-ci-robot commented Nov 11, 2024 •

edited by openshift-ci bot

Loading

ocpdocs-previewbot commented Nov 11, 2024 •

edited

Loading

openshift-ci-robot commented Nov 25, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 12, 2025 •

edited by openshift-ci bot

Loading