Skip to content

OCPBUGS-41971-ent18: Added note to the Ingress capability docs #84867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

OCPBUGS-41971-ent18: Added note to the Ingress capability docs #84867

merged 1 commit into from
Nov 18, 2024
+5 −2

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Nov 13, 2024 •
edited
Loading

Version(s):
4.18

Issue:
OCPBUGS-41971

Link to docs preview:

  • SME has approved this change (Trevor King/Seth Jennings/Cesar Wong).
  • QE has approved this change (QE on 84252).

Additional information:

  • Do not turn off the Ingress Capability feature for 4.16 plus on OCP core and HCPs?

SETH confirmed that the ingress capability is out of scope for 4.16 and 4.17.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 13, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 13, 2024 •
edited
Loading

🤖 Mon Nov 18 10:44:27 - Prow CI generated the docs preview:

https://84867--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/overview/cluster-capabilities.html
https://84867--ocpdocs-pr.netlify.app/openshift-enterprise/latest/operators/operator-reference.html

@dfitzmau dfitzmau force-pushed the OCPBUGS-41971-ent18 branch from 4675cb0 to 9a28540 Compare November 15, 2024 16:09
wking
wking approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calls out the need to not disable this capability, and aligns with the 4.17 and older wording in #84252.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
@wking wking mentioned this pull request Nov 15, 2024
Merged
2 tasks
@dfitzmau dfitzmau added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 15, 2024
@lahinson lahinson added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 15, 2024
lahinson
lahinson reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few small items for your consideration.

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 15, 2024
@lahinson lahinson added this to the Planned for 4.18 GA milestone Nov 15, 2024
lahinson
lahinson reviewed Nov 15, 2024
View reviewed changes
@dfitzmau dfitzmau force-pushed the OCPBUGS-41971-ent18 branch from 9a28540 to eb6f009 Compare November 18, 2024 10:34
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 18, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 18, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau merged commit 6c2d011 into openshift:main Nov 18, 2024
2 checks passed
@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.18

@openshift-cherrypick-robot
Copy link

@bscott-rh: new pull request created: #92673

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahinson lahinson

@wking wking

Assignees

@wking wking

Labels
branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.18 GA
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dfitzmau @ocpdocs-previewbot @bscott-rh @openshift-cherrypick-robot @wking @lahinson