Skip to content

Update ingress-operator.adoc #84979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rameshsahoo111
Copy link
Contributor

@rameshsahoo111 rameshsahoo111 commented Nov 14, 2024

Added a solution article link to this document for the original client IP details.

Version(s):

Issue:

Link to docs preview: https://84979--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ingress-operator.html#additional-resources

QE review:

  • QE has approved this change.

Additional information:

Added a solution article link to this document for the original client IP details.
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2024
Copy link

openshift-ci bot commented Nov 14, 2024

Hi @rameshsahoo111. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 14, 2024
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for opening! small edit to the existing link. when you've made the change, feel free to ping me

endif::openshift-rosa,openshift-dedicated[]
* link:https://access.redhat.com/solutions/7096271k[Viewing the original client source IP through the X-Forwarded-For header in OpenShift Ingress access log]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current link doesn't work, but this does:

Suggested change
* link:https://access.redhat.com/solutions/7096271k[Viewing the original client source IP through the X-Forwarded-For header in OpenShift Ingress access log]
* link:https://access.redhat.com/solutions/7096271[Viewing the original client source IP through the X-Forwarded-For header in OpenShift Ingress access log]

@jldohmann
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2024
@jldohmann jldohmann added this to the Continuous Release milestone Nov 19, 2024
endif::openshift-rosa,openshift-dedicated[]
* link:https://access.redhat.com/solutions/7096271k[Viewing the original client source IP through the X-Forwarded-For header in OpenShift Ingress access log]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* link:https://access.redhat.com/solutions/7096271k[Viewing the original client source IP through the X-Forwarded-For header in OpenShift Ingress access log]
* link:https://access.redhat.com/solutions/7096271k[Viewing the original client source IP through the X-Forwarded-For header in {product-title} Ingress access log]

Copy link

openshift-ci bot commented Nov 19, 2024

@rameshsahoo111: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jldohmann
Copy link
Contributor

@melvinjoseph86 can you PTAL at this docs PR for QE ack? thank you

@jldohmann
Copy link
Contributor

@rameshsahoo111 what version(s) of OCP do you mean for this change to apply to?

Copy link

@melvinjoseph86 melvinjoseph86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label qe-approved

endif::openshift-rosa,openshift-dedicated[]
* link:https://access.redhat.com/solutions/7096271k[Viewing the original client source IP through the X-Forwarded-For header in OpenShift Ingress access log]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 20, 2024
@jldohmann jldohmann added the peer-review-done Signifies that the peer review team has reviewed this PR label Nov 20, 2024
@rameshsahoo111
Copy link
Contributor Author

@rameshsahoo111 what version(s) of OCP do you mean for this change to apply to?

Please apply this to all OCP 4.x version.

@rameshsahoo111
Copy link
Contributor Author

@rameshsahoo111 what version(s) of OCP do you mean for this change to apply to?

Please apply this to all OCP 4.x version.

I would also request changing the heading as below;

FROM:
Viewing the original client source IP through the X-Forwarded-For header in OpenShift Ingress access log

TO:
Viewing the original client IP through the X-Forwarded-For header in OpenShift Ingress access logs or within applications logs deployed on OpenShift

@jldohmann
Copy link
Contributor

@rameshsahoo111 that sounds fine, just remember to use the attribute {product-title} in place of OpenShift when making the change 😄

@rameshsahoo111
Copy link
Contributor Author

{product-title}

yes, sure. Thank you.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2024
@rameshsahoo111
Copy link
Contributor Author

New pull request available at #86578

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.19 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.18. And any PR going into main must also target the latest version branch (enterprise-4.19).

If the update in your PR does NOT apply to version 4.19 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@rameshsahoo111
Copy link
Contributor Author

Thank you, please merge the pr

@bergerhoffer
Copy link
Contributor

@rameshsahoo111 There is a conflict now, so this PR needs to be rebased (and then squashed to 1 commit).

Or if you can't do that, you can always open it as a new PR. Please ping @jldohmann for help (my comment was just a standard boilerplate for cutting a new version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants