-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update ingress-operator.adoc #84979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update ingress-operator.adoc #84979
Conversation
Added a solution article link to this document for the original client IP details.
Hi @rameshsahoo111. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for opening! small edit to the existing link. when you've made the change, feel free to ping me
endif::openshift-rosa,openshift-dedicated[] | ||
* link:https://access.redhat.com/solutions/7096271k[Viewing the original client source IP through the X-Forwarded-For header in OpenShift Ingress access log] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the current link doesn't work, but this does:
* link:https://access.redhat.com/solutions/7096271k[Viewing the original client source IP through the X-Forwarded-For header in OpenShift Ingress access log] | |
* link:https://access.redhat.com/solutions/7096271[Viewing the original client source IP through the X-Forwarded-For header in OpenShift Ingress access log] |
/ok-to-test |
endif::openshift-rosa,openshift-dedicated[] | ||
* link:https://access.redhat.com/solutions/7096271k[Viewing the original client source IP through the X-Forwarded-For header in OpenShift Ingress access log] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* link:https://access.redhat.com/solutions/7096271k[Viewing the original client source IP through the X-Forwarded-For header in OpenShift Ingress access log] | |
* link:https://access.redhat.com/solutions/7096271k[Viewing the original client source IP through the X-Forwarded-For header in {product-title} Ingress access log] |
@rameshsahoo111: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@melvinjoseph86 can you PTAL at this docs PR for QE ack? thank you |
@rameshsahoo111 what version(s) of OCP do you mean for this change to apply to? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label qe-approved
endif::openshift-rosa,openshift-dedicated[] | ||
* link:https://access.redhat.com/solutions/7096271k[Viewing the original client source IP through the X-Forwarded-For header in OpenShift Ingress access log] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working links is 'https://access.redhat.com/solutions/7096271'
Please apply this to all OCP 4.x version. |
I would also request changing the heading as below; FROM: TO: |
@rameshsahoo111 that sounds fine, just remember to use the attribute |
yes, sure. Thank you. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
New pull request available at #86578 |
The This is because your PR targets the If the update in your PR does NOT apply to version 4.19 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
Thank you, please merge the pr |
@rameshsahoo111 There is a conflict now, so this PR needs to be rebased (and then squashed to 1 commit). Or if you can't do that, you can always open it as a new PR. Please ping @jldohmann for help (my comment was just a standard boilerplate for cutting a new version). |
Added a solution article link to this document for the original client IP details.
Version(s):
Issue:
Link to docs preview: https://84979--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ingress-operator.html#additional-resources
QE review:
Additional information: