Skip to content

Update log6x-audit-log-filtering.adoc #85035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update log6x-audit-log-filtering.adoc #85035

wants to merge 3 commits into from

Conversation

amandverma
Copy link

@amandverma amandverma commented Nov 15, 2024 •
edited
Loading

Updated line 48 to 51, as inputRefs and filterRefs are accepting array type of value.

Doc bug for clf.spec.pipeline.inputRefs|outputRefs|filterRefs should of array type instead of string.

Version(s):

4.14 - 4.17
Issue:

https://issues.redhat.com/browse/OBSDOCS-970
Link to docs preview:

https://85035--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.0/log6x-clf.html
https://85035--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.1/log6x-clf-6.1.html
QE review:

  • QE has approved this change.

Additional information:

@amandverma
Update log6x-audit-log-filtering.adoc
e7f44da 
Updated line 48 to 51, as inputRefs and filterRefs are accepting array type of value.
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 15, 2024 •
edited
Loading

🤖 Tue Dec 24 14:02:40 - Prow CI generated the docs preview:

https://85035--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.0/log6x-clf.html
https://85035--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.1/log6x-clf-6.1.html

@amandverma
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 15, 2024
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.17 labels Nov 15, 2024
lahinson
lahinson reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Otherwise, looks good! Be sure to get QE approval before you move this to merge review. Also, is this change going into 4.17 only?

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 15, 2024
@amandverma
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 19, 2024
@lahinson lahinson added this to the Continuous Release milestone Nov 19, 2024
lahinson
lahinson reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Be sure to squash your commits down to 1. Thanks!

@lahinson lahinson removed the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 19, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 24, 2024

@amandverma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 25, 2025
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahinson lahinson lahinson left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
4 participants
@amandverma @ocpdocs-previewbot @openshift-bot @lahinson