Skip to content

OSDOCS-12422#VolumeAttributesClass TP #85302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSDOCS-12422#VolumeAttributesClass TP #85302

wants to merge 1 commit into from

Conversation

lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Nov 21, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2024
@lpettyjo lpettyjo added branch/enterprise-4.18 peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 21, 2024
@lpettyjo lpettyjo added this to the Planned for 4.18 GA milestone Nov 21, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 21, 2024 •
edited
Loading

🤖 Mon May 19 18:06:09 - Prow CI generated the docs preview:

https://85302--ocpdocs-pr.netlify.app/openshift-dedicated/latest/storage/understanding-persistent-storage.html
https://85302--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/understanding-persistent-storage.html
https://85302--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/understanding-persistent-storage.html
https://85302--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/understanding-persistent-storage.html

gcharot
gcharot reviewed Nov 22, 2024
View reviewed changes
modules/storage-persistent-storage-pvc-volumeattributesclass.adoc Outdated

To apply a Volume Attribute Class to a PVC:

* Set the PVC's `volumeAttributesClassName` parameter to the Volume Attribute Class's name:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restate that this field can be update on existing bound PVC? @gnufied

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@lpettyjo lpettyjo force-pushed the OSDOCS-12422 branch 4 times, most recently from 94d4f74 to 2f2ca1b Compare November 23, 2024 01:17
@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 23, 2024
GroceryBoyJr
GroceryBoyJr reviewed Nov 23, 2024
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one small nit.

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 23, 2024
@gcharot
Copy link

gcharot commented Mar 14, 2025

if openshift/gcp-pd-csi-driver#75 merges please add GCP PD to the list of drivers that support this feature.

gnufied
gnufied reviewed Mar 18, 2025
View reviewed changes
modules/storage-persistent-storage-pvc-volumeattributesclass.adoc Outdated
:FeatureName: Volume Attributes Classes
include::snippets/technology-preview.adoc[leveloffset=+1]

Volume Attributes Classes in {product-title} is available only with AWS Elastic Block Storage (EBS) Container Storage Interface (CSI).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now available with GCP-PD CSI driver too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added GCP.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature works with GCP-PD only when diskType is "hyperdisk" eg., "hyperdisk-balanced". We might want to add this as a limitation for GCP? cc. @dfajmon

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. This limitation should be mentioned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

gnufied
gnufied reviewed Apr 25, 2025
View reviewed changes
modules/storage-persistent-storage-pvc-volumeattributesclass.adoc Outdated
== Limitations
Volume Attributes Classes has the following limitations:

* When using with GCP, `diskType` must be set to `hyperdisk-balanced`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true? where is this coming from? hyperdisk should only be available on certain instance types.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VolumeAttributesClasses are supported only for hyperdisks.
Hyperdisks are only available for C3 and N4 instances.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VAC feature is supported on all hyperdisk types which are, 'hyperdisk-balanced', 'hyperdisk-extreme', 'hyperdisk-ml', 'hyperdisk-throughput'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only claim support for hyperdisk-balanced IIRC

Copy link
Contributor Author

@lpettyjo lpettyjo May 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcharot @radeore @dfajmon So are we going with hyperdisk-balanced only as to what we support?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we will be going only with hyperdisk-balanced. I talked with @radeore, and we agreed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using with GCP, diskType must be set to hyperdisk-balanced.

hmm, this reads weird. It should rather say, volume modifications via volumeattributes are only possible for hyperdisk-balanced disk types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@lpettyjo lpettyjo force-pushed the OSDOCS-12422 branch 2 times, most recently from 95f5e79 to b5d0287 Compare May 8, 2025 16:59
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2025
gnufied
gnufied reviewed May 13, 2025
View reviewed changes
modules/storage-persistent-storage-pvc-volumeattributesclass.adoc Outdated

You can apply a Volume Attributes Class to a persistent volume claim (PVC). If a new Volume Attributes Class becomes available in the cluster, a user can update the PVC with the new Volume Attributes Class if needed.

Volume Attributes Classes have parameters that describe volumes belonging to them. Different parameters can be accepted depending on the provisioner or the resizer. If a parameter is omitted, the default is used at volume provisioning. If you apply the PVC with a different Volume Attributes Class with omitted parameters, the default value of the parameters might be used depending on the CSI driver implementation. For more information, see the related CSI driver documentation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different parameters can be accepted depending on the provisioner or the resizer.

No the parameters are property of CSI driver. And are opaque to provisioner or resizer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just deleted that sentence.

@lpettyjo lpettyjo force-pushed the OSDOCS-12422 branch 2 times, most recently from f5831d2 to 2e41d93 Compare May 15, 2025 14:52
dfajmon
dfajmon approved these changes May 16, 2025
View reviewed changes
Copy link

@dfajmon dfajmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chao007
Copy link

chao007 commented May 16, 2025

LGTM

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 19, 2025

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@gcharot gcharot gcharot left review comments

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@radeore radeore radeore left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@dfajmon dfajmon dfajmon approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.19 GA
Development

Successfully merging this pull request may close these issues.
10 participants
@lpettyjo @ocpdocs-previewbot @GroceryBoyJr @gcharot @chao007 @gnufied @radeore @ocpdocs-vale-bot @dfajmon @kalexand-rh