Skip to content

OCPBUGS#45054: Maintain linear nomenclature for nodes in the "Installing Cluster on any platform" documentation #85475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Atharva-Shinde
Copy link

@Atharva-Shinde Atharva-Shinde commented Nov 26, 2024

Version(s): 4.17, 4.16, 4.15, 4.14, 4.13, 4.12

Issue: Jira Ticket

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Changed the node names in the HAProxy configuration from master<> to control-plane<>

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2024
Copy link

openshift-ci bot commented Nov 26, 2024

Hi @Atharva-Shinde. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k37y
Copy link
Contributor

k37y commented Nov 26, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 26, 2024

🤖 Tue Dec 03 05:52:17 - Prow CI generated the docs preview:
https://85475--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

… of the platform agnostic cluster installation documentation
@k37y
Copy link
Contributor

k37y commented Dec 2, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 2, 2024
@adellape adellape self-assigned this Dec 2, 2024
@adellape adellape added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Dec 2, 2024
@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 2, 2024
@adellape adellape added this to the Continuous Release milestone Dec 2, 2024
Copy link

openshift-ci bot commented Dec 3, 2024

@Atharva-Shinde: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Atharva-Shinde
Copy link
Author

Hey @adellape any updates on this PR?

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.19 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.18. And any PR going into main must also target the latest version branch (enterprise-4.19).

If the update in your PR does NOT apply to version 4.19 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants