Update dynamic-provisioning-vsphere-definition.adoc #85880
Conversation
openshift-ci
bot
added
size/XS
|
Hi @sbiradar10. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sbiradar10: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/peer-review-needed |
|
@skhette: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/peer-review-needed |
1 similar comment
|
/peer-review-needed |
lpettyjo
added
the
peer-review-in-progress
| ---- | ||
| <1> Name of the storage class. The persistent volume claim uses this storage class for provisioning the associated persistent volumes. | ||
| <2> For more information about using VMware vSphere CSI with {product-title}, | ||
| <3> XFS or EXT4 are supported filesystem type for vSphere CSI Driver. |
There was a problem hiding this comment.
Change to: "The vSphere CSI driver supports all of the file systems supported by the underlying Red Hat Core operating system release, including XFS and Ext4."
|
/peer-review-needed |
| @@ -13,8 +13,11 @@ apiVersion: storage.k8s.io/v1 | |||
| metadata: | |||
| name: <storage-class-name> <1> | |||
| provisioner: csi.vsphere.vmware.com <2> | |||
| parameters: | |||
| csi.storage.k8s.io/fstype: xfs <3> | |||
| ---- | |||
There was a problem hiding this comment.
So this parameter is not specific to vSphere CSI driver and should be supported by all CSI drivers. A better place to document this is perhaps - https://docs.openshift.com/container-platform/4.17/storage/container_storage_interface/persistent-storage-csi.html#csi-dynamic-provisioning_persistent-storage-csi
There was a problem hiding this comment.
Hey @gnufied so do you want me to edit the files and modify for above doc url ? instead of specific vsphere?
|
@sbiradar10: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
LTGM |
|
The This is because your PR targets the If the update in your PR does NOT apply to version 4.19 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
|
Hello @bergerhoffer Thank you for the reply. |
|
/peer-review-needed |
lpettyjo
added
peer-review-done
|
/peer-review-needed |
|
LGTM |
Adding parameter section in storage class object definition.
Version(s): 4.14 to latest version
Issue: Good to have parameter section in sc for vSphere CSI driver
Link to docs preview: https://docs.openshift.com/container-platform/4.17/storage/dynamic-provisioning.html#vsphere-definition_dynamic-provisioning
QE review:
Additional information: We can add multiple parameter in storageclass object for vSphere CSI so having example definition would be great in official doc. For example , having supported filesystem type for vsphere csi storageclass object definition.
PTAL: @gnufied @gcharot @duanwei33