-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS-48180: modules/containers-signature-verify-skopeo: security.access.redhat.com key source #86821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…m key source Current outgoing docs are from 33130f4 (OCPBUGS#19749: add verification for unsigned containers, 2024-01-09, openshift#68949) and they recommend: $ curl -o pub.key https://access.redhat.com/security/data/fd431d51.txt But in 2024-09, that content was moved to a new location (with a 301 redirect): $ curl -isL https://access.redhat.com/security/data/fd431d51.txt | grep -i 'HTTP\|Location\|PUBLIC' HTTP/2 301 location: https://security.access.redhat.com/data/fd431d51.txt HTTP/1.1 200 OK -----BEGIN PGP PUBLIC KEY BLOCK----- -----END PGP PUBLIC KEY BLOCK----- And the currently-doc'ed command (which does not allow redirects) will exit 0 (success) while downloading an empty file: $ curl -o pub.key https://access.redhat.com/security/data/fd431d51.txt % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 $ echo $? 0 $ wc -l pub.key 0 pub.key This commit pivots to the new canonical location. And it adds the -L/--location option to protect ourselves from future moves. $ man curl | grep -1 'moved to a different location' -L, --location (HTTP) If the server reports that the requested page has moved to a different location (indicated with a Location: header and a 3XX response code), this option will make curl redo the request on the new place. If used together with -i, --include or -I, --head, headers from all requested pages will be shown. When authentication is used, curl only sends its credentials to the ini‐
@wking: This pull request references Jira Issue OCPBUGS-48180, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@wking: This pull request references Jira Issue OCPBUGS-48180, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Wed Jan 08 17:50:52 - Prow CI generated the docs preview: |
@wking: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@wking: This pull request references Jira Issue OCPBUGS-48180, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The This is because your PR targets the If the update in your PR does NOT apply to version 4.19 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
@lyman9966 Could you please take a look? Thanks. |
@lyman9966 can you PTAL? cc @wking |
/label merge-review-needed |
/remove-label merge-review-needed |
/tide refresh |
Version(s): 4.12+
Issue:
OCPBUGS-48180
Link to docs preview:
Using skopeo to verify signatures of Red Hat container images, step 2
QE review: