Skip to content

[GH#87271] Add information about the openshift-service-ca.crt ConfigMap #87272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jamstah
Copy link

@Jamstah Jamstah commented Jan 20, 2025

The openshift kube-controller-manager maintains a ConfigMap in every namespace that publishes the service serving certifcate CA. Adding it to the documentation for users.

Version(s):
This functionality has existed since OpenShift 4.12.

Issue:
#87271

Link to docs preview:
https://87272--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/certificates/service-serving-certificate.html

QE review:

  • QE has approved this change.

Additional information:

The openshift kube-controller-manager maintains a ConfigMap in every namespace that publishes the service serving certifcate CA.
Adding it to the documentation for users.

Signed-off-by: James Hewitt <[email protected]>
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2025
Copy link

openshift-ci bot commented Jan 20, 2025

Hi @Jamstah. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Jamstah
Copy link
Author

Jamstah commented Jan 20, 2025

Hi @openshift/team-documentation, can I please have an OK to test on this one.

@bergerhoffer
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2025
@bergerhoffer
Copy link
Contributor

/retest

@bergerhoffer
Copy link
Contributor

@Jamstah thanks for submitting this! Something funky is going on with our tests, but I'll help move this along (need to get engineering/QE review as well).

I'll probably have some nits about the files - are you okay with making the updates if I point them out (and then squashing the commits afterward), or would you prefer me to take over the PR to make those final updates?

@bergerhoffer
Copy link
Contributor

/retest

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 20, 2025

@bergerhoffer
Copy link
Contributor

@tkashem @wangke19 Can you confirm whether this is accurate and okay to document?

@Jamstah
Copy link
Author

Jamstah commented Jan 21, 2025

I'll probably have some nits about the files - are you okay with making the updates if I point them out (and then squashing the commits afterward), or would you prefer me to take over the PR to make those final updates?

However you like to work :)

Copy link

openshift-ci bot commented Jan 21, 2025

@Jamstah: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.19 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.18. And any PR going into main must also target the latest version branch (enterprise-4.19).

If the update in your PR does NOT apply to version 4.19 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@Jamstah
Copy link
Author

Jamstah commented Feb 25, 2025

@tkashem @wangke19 please review :)

@Jamstah
Copy link
Author

Jamstah commented Mar 18, 2025

@bergerhoffer is there anyone else who can approve?

@bergerhoffer
Copy link
Contributor

Sorry for the delay, I've pinged again, we'll try to get someone soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants