Skip to content

OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. #87634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AedinC
Copy link
Contributor

@AedinC AedinC commented Jan 27, 2025

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 27, 2025
@AedinC AedinC changed the title OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. [WIP]OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. Jan 27, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch 2 times, most recently from 1ad928d to 005fba0 Compare January 28, 2025 15:25
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from 005fba0 to 5694f45 Compare January 28, 2025 16:06
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch 4 times, most recently from f6754f0 to db8df98 Compare February 6, 2025 11:20
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from db8df98 to 1fe8c6f Compare February 7, 2025 08:38
@AedinC
Copy link
Contributor Author

AedinC commented Feb 7, 2025

@andreadecorte Can you please review this when you get a chance? Many thanks.

@AedinC
Copy link
Contributor Author

AedinC commented Feb 11, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 11, 2025
@adellape adellape self-assigned this Feb 11, 2025
@adellape adellape added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 11, 2025
@adellape adellape added this to the Planned for 4.18 GA milestone Feb 11, 2025
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 11, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from 1fe8c6f to 6f61720 Compare February 12, 2025 11:54
@AedinC AedinC changed the title [WIP]OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. Feb 12, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2025
Copy link

openshift-ci bot commented Feb 12, 2025

@AedinC: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2025
@AedinC
Copy link
Contributor Author

AedinC commented May 26, 2025

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants