Skip to content

OSDOCS-12356: Add OVN-Kubernetes secondary network mapping #87994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSDOCS-12356: Add OVN-Kubernetes secondary network mapping #87994

wants to merge 1 commit into from

Conversation

jab-rh
Copy link
Contributor

@jab-rh jab-rh commented Feb 4, 2025 •
edited
Loading

Version(s): 4.18+

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@jab-rh jab-rh added this to the Planned for 4.18 GA milestone Feb 4, 2025
@jab-rh jab-rh self-assigned this Feb 4, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 4, 2025 •
edited by openshift-ci bot
Loading

@jab-rh: This pull request references OSDOCS-12356 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 4, 2025 •
edited by openshift-ci bot
Loading

@jab-rh: This pull request references OSDOCS-12356 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 4, 2025 •
edited
Loading

🤖 Mon Feb 17 06:20:59 - Prow CI generated the docs preview:

https://87994--ocpdocs-pr.netlify.app/
https://87994--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/secondary_networks/creating-secondary-nwt-ovnk.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2025 •
edited by openshift-ci bot
Loading

@jab-rh: This pull request references OSDOCS-12356 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.18

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@maiqueb
Copy link

maiqueb commented Feb 7, 2025

cc @maiqueb @RamLavi

@jab-rh
Copy link
Contributor Author

jab-rh commented Feb 11, 2025

Hi @qiowang721, can you take a look at this docs update and confirm that it looks okay? Thanks!

@jab-rh jab-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 11, 2025
@ShaunaDiaz ShaunaDiaz added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 11, 2025
ShaunaDiaz
ShaunaDiaz reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit; and remember to squash the commits

@ShaunaDiaz ShaunaDiaz added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 11, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 17, 2025

@jab-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@qiowang721
Copy link

Hi @jab-rh , as mentioned in PR 87995, QE does not have a 4.18 testing EPICs to validate this new setting of "physicalNetworkName", so i think we should not advertise the feature as supported until QE fully tests it.
@gsr-shanks / @weliang1 WDYT?

@qiowang721
Copy link

@Anatw I see you verified the bug https://issues.redhat.com/browse/OCPBUGS-31679, which related to the new feature, could you help to review the docs PR? Please correct me if i ping wrong person. Thanks a lot!

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.19 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.18. And any PR going into main must also target the latest version branch (enterprise-4.19).

If the update in your PR does NOT apply to version 4.19 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@jab-rh jab-rh mentioned this pull request Apr 3, 2025
Open
1 task
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 9, 2025 •
edited by openshift-ci bot
Loading

@jab-rh: This pull request references OSDOCS-12356 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.18+

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jab-rh
Copy link
Contributor Author

jab-rh commented May 2, 2025

Cleared by QE: #89471 (comment)

maiqueb
maiqueb approved these changes May 3, 2025
View reviewed changes
Copy link

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

@maiqueb maiqueb maiqueb approved these changes

Assignees

@jab-rh jab-rh

Labels
branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
8 participants
@jab-rh @openshift-ci-robot @ocpdocs-previewbot @maiqueb @qiowang721 @bergerhoffer @ShaunaDiaz @kalexand-rh