Skip to content

TRACING-4630 |RHOSDT 3.6 | Tempo query RBAC #88971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Feb 20, 2025

Version(s):

OCP 4.12-4.19
RHOSDT: 3.6

Issue:

https://issues.redhat.com/browse/TRACING-4630

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

TODO:

  • Document which minimal RBAC is needed and test it

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2025
Copy link

openshift-ci bot commented Feb 20, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pavolloffay
Copy link
Member Author

/test all

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 20, 2025
Signed-off-by: Pavol Loffay <[email protected]>
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: tempo-dev-read
subjects:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
subjects:

line is twice in the example

.Command to give authenticated users access to the project `project1`.
[source,bash]
----
oc adm policy add-role-to-group view system:authenticated -n tutorial-application-backend2 # <1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the example, I think giving access to all authenticated users is too broad access, I'd suggest e.g.

oc adm policy add-role-to-user view alice -n tutorial-application-backend2

(using alice from the example here: https://docs.openshift.com/container-platform/4.18/authentication/using-rbac.html#adding-roles_using-rbac)

@pavolloffay pavolloffay changed the title TRACING-4630 | Tempo query RBAC TRACING-4630 |RHOSDT 3.6 | Tempo query RBAC Mar 20, 2025
@max-cx
Copy link
Contributor

max-cx commented May 15, 2025

Pavol, feel free to close this PR because I opened #93417.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants