-
Notifications
You must be signed in to change notification settings - Fork 1.8k
TRACING-4630 |RHOSDT 3.6 | Tempo query RBAC #88971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Pavol Loffay <[email protected]>
Skipping CI for Draft Pull Request. |
/test all |
Signed-off-by: Pavol Loffay <[email protected]>
apiGroup: rbac.authorization.k8s.io | ||
kind: ClusterRole | ||
name: tempo-dev-read | ||
subjects: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subjects: |
line is twice in the example
.Command to give authenticated users access to the project `project1`. | ||
[source,bash] | ||
---- | ||
oc adm policy add-role-to-group view system:authenticated -n tutorial-application-backend2 # <1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the example, I think giving access to all authenticated users is too broad access, I'd suggest e.g.
oc adm policy add-role-to-user view alice -n tutorial-application-backend2
(using alice
from the example here: https://docs.openshift.com/container-platform/4.18/authentication/using-rbac.html#adding-roles_using-rbac)
Pavol, feel free to close this PR because I opened #93417. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
OCP 4.12-4.19
RHOSDT: 3.6
Issue:
https://issues.redhat.com/browse/TRACING-4630
Link to docs preview:
QE review:
Additional information:
TODO: