Skip to content

[enterprise-4.17] TELCODOCS#2177: Refactor Edge Computing to improve ToC navigation #89599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: enterprise-4.17
Choose a base branch
from
Open

[enterprise-4.17] TELCODOCS#2177: Refactor Edge Computing to improve ToC navigation #89599

wants to merge 1 commit into from

Conversation

sr1kar99
Copy link
Contributor

@sr1kar99 sr1kar99 commented Mar 5, 2025 •
edited
Loading

Version(s):
4.17

Issue:
TELCODOCS-2177

Link to docs preview:

Note to the merge reviewer: This PR updates the name of the "Edge computing" book to "GitOps ZTP" and also moves a couple of sections under GitOps ZTP chapter up a level. Hence, QE and SME acks were not requested.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 5, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 5, 2025 •
edited
Loading

🤖 Wed Mar 05 21:06:20 - Prow CI generated the docs preview:
https://89599--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@sr1kar99 sr1kar99 force-pushed the 2177-4-17-toc branch 3 times, most recently from 98ae8fe to 94f7868 Compare March 5, 2025 20:10
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 5, 2025
@sr1kar99 sr1kar99 force-pushed the 2177-4-17-toc branch 4 times, most recently from b82c809 to ae47bc1 Compare March 5, 2025 20:46
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 5, 2025

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented Mar 5, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 5, 2025
@snarayan-redhat snarayan-redhat added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 6, 2025
snarayan-redhat
snarayan-redhat reviewed Mar 6, 2025
View reviewed changes
Copy link
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Left few comments.

@snarayan-redhat snarayan-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 6, 2025
@sr1kar99
Copy link
Contributor Author

sr1kar99 commented Mar 6, 2025

Good work. Left few comments.

Thank you for the thorough review, @snarayan-redhat. I’d like to address these changes in a separate PR, as this one is only for moving a few directories up a level.

@snarayan-redhat
Copy link
Contributor

Good work. Left few comments.

Thank you for the thorough review, @snarayan-redhat. I’d like to address these changes in a separate PR, as this one is only for moving a few directories up a level.

sure, works!

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented Mar 7, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 7, 2025
@skrthomas skrthomas added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 7, 2025
@sr1kar99
Copy link
Contributor Author

/remove-label merge-review-in-progress

@openshift-ci openshift-ci bot removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarayan-redhat snarayan-redhat snarayan-redhat left review comments

Assignees
No one assigned
Labels
peer-review-done Signifies that the peer review team has reviewed this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sr1kar99 @ocpdocs-previewbot @snarayan-redhat @skrthomas