OCPBUGS-51174: Updated the changing-cluster-network-mtu file with NIC… #89757

dfitzmau · 2025-03-06T14:44:25Z

Version(s):
4.12+

Link to docs preview:

SME has approved this change (Kevin Anderson).
QE has approved this change (Anurag Saxena/Jaime Caamano).

More clarifications needed.

openshift-ci-robot · 2025-03-06T14:44:28Z

@dfitzmau: No Jira issue with key OCPBUGS-55174 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

… info

Version(s):

Issue:

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-03-06T14:45:01Z

@dfitzmau: No Jira issue with key OCPBUGS-55174 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.12+

Issue:
OCPBUGS-51174

Link to docs preview:

SME has approved this change.

QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2025-03-06T15:04:09Z

🤖 Fri Mar 21 16:56:58 - Prow CI generated the docs preview:
https://89757--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

openshift-ci-robot · 2025-03-06T15:28:00Z

@dfitzmau: No Jira issue with key OCPBUGS-55174 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.12+

Issue:
OCPBUGS-51174

Link to docs preview:

AWS Local Zone or Wavelength Zone tasks

Extending an AWS VPC cluster into an AWS Outpost

Changing the MTU for the cluster network

SME has approved this change.

QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kevin-anderson-redhat · 2025-03-07T20:46:34Z

modules/nw-cluster-mtu-change.adoc

+[source,ini]
+----
+[connection-<primary-NIC-bond-interface>-mtu]
+match-device=interface-name:<bond-iface-name>


There are normally at least 2 interfaces assigned to a bond, I think it would be more clear to show two.
This solution article How to change bond MTU shows 2 slave interfaces.
To make this truly be an "Example", it might be more helpful to use eth0 and eth1:

[bond0-mtu] match-device=interface-name:bond0 ethernet.mtu=9000 [connection-eth0-mtu] match-device=interface-name:eth0 ethernet.mtu=9000 [connection-eth1-mtu] match-device=interface-name:eth1 ethernet.mtu=9000

Thanks for that info. Updated!

modules/nw-cluster-mtu-change.adoc

openshift-ci-robot · 2025-03-10T11:42:44Z

@dfitzmau: This pull request references Jira Issue OCPBUGS-51174, which is invalid:

expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
4.12+

Issue:
OCPBUGS-51174

Link to docs preview:

AWS Local Zone or Wavelength Zone tasks

Extending an AWS VPC cluster into an AWS Outpost

Changing the MTU for the cluster network

SME has approved this change.

QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kevin-anderson-redhat · 2025-03-10T13:37:54Z

LGTM

jldohmann

Mostly LGTM! some comments and suggestions below

modules/nw-cluster-mtu-change.adoc

jldohmann · 2025-03-10T15:59:58Z

modules/nw-cluster-mtu-change.adoc

-`<machine_to>`:: Specifies the MTU for the primary network interface on the underlying host network.
--
+<1> Where `<overlay_from>` specifies the current cluster network MTU value.
+<2> Where `<overlay_to>` specifies the target MTU for the cluster network. This value is set relative to the value of 


This callout is cut off

modules/nw-cluster-mtu-change.adoc

dfitzmau · 2025-03-11T10:48:33Z

/retest

anuragthehatter · 2025-03-19T21:57:44Z

Looks good to me. I would like @jcaamano to take a look as well

… info

dfitzmau · 2025-03-21T16:45:39Z

modules/nw-cluster-mtu-change.adoc

 +
 ifndef::outposts[]
 .Example that increases the cluster MTU
 [source,terminal]
 ----
 $ oc patch Network.operator.openshift.io cluster --type=merge --patch \
-  '{"spec": { "migration": { "mtu": { "network": { "from": 1400, "to": 9000 } , "machine": { "to" : 9100} } } } }'
+  '{"spec": { "migration": { "mtu": { "network": { "from": 1400, "to": 8900 } , "machine": { "to" : 9000} } } } }'


This change stemmed from https://issues.redhat.com/browse/OSDOCS-13689.

openshift-ci · 2025-03-21T16:58:20Z

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jcaamano · 2025-03-28T14:28:56Z

modules/nw-cluster-mtu-change.adoc

 ----
+<1> Where `<node_name>` specifies the name of a node in your cluster.
+<2> Where `ovs-if-phys0` is the primary network interface. For nodes that use multiple NIC bonds, append `bond-sub0` for the primary NIC bond interface and `bond-sub1` for the secondary NIC bond interface.


Append to what? Where does bond-sub0 and bond-sub1 come from?

jcaamano · 2025-03-28T14:32:59Z

modules/nw-cluster-mtu-change.adoc

-where:
+[NOTE]
+====
+For nodes that use a network interface controller (NIC) bond interface, list the bond interface and any sub-interfaces in the `<bond-interface>-mtu.conf` file. 


Where does this information come from? The MTU of the sub-interfaces should automatically acquire the same MTU of the bond interface.

I don't see the <bond-interface>-mtu.conf mentioned before in this document.

@jcaamano There are 2 things that come to mind with respect to the procedure as written:

The docs does not address bonded NICs or VLANs at all. It is left as an exercise for the reader to extrapolate the documented steps, covering a single NIC, to multiple NICs under a bond

The OpenShift agent based installer for bare metal systems allows for the MTU to be specified on each "interface"; sub NICs, bond, VLAN. If, during install, we set the MTU at all 3 levels, for some reason, and then we apply the MTU change procedure only to the sub NICs of the bond, will the bond and the vlan interfaces inherit the new sub NIC configuration, or, will the fact that I specifically set the MTU level at all 3 places during install mean that the sub NICs have the new MTU but the bond and vlan interfaces have the old MTU because there was an actual setting provided and not just inherited?

If on the other hand, changing the sub NIC interfaces' MTU would propagate then item 1 is really the primary concern. Leaving the extrapolation of the procedure as an exercise for the reader is risky and actually did impact one of our systems.

@dmc5179

What do you feel this doc need to address about bonds that is missing? To my knowledge, the procedure would be exactly the same with bonds.

You don't need to specify the MTU of the subordinates of the bond. They automatically acquire the MTU of the parent. Maybe this is what is being the problem but unknown without taking a deeper look. In any case, it would be impossible for this procedure to cover, or be aware of, all possible network configurations. I had already submitted a PR to add that disclaimer to this doc, I will dig that PR up.

Disclaimer Jira: https://issues.redhat.com/browse/OCPBUGS-17933

jcaamano · 2025-03-28T14:36:37Z

modules/nw-cluster-mtu-change.adoc

-<2> Specify the local filename for the updated NetworkManager configuration file from the previous step.
-
-.... Create the following Butane config in the `worker-interface.bu` file:
+<2> Specify the local filename for the updated NetworkManager configuration file from the previous step. For NIC bonds, specify the name for the `<bond-interface>-mtu.conf` file.


I don't see why <interface> would be different than <bond-interface>

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 6, 2025

dfitzmau force-pushed the OCPBUGS-51174 branch 3 times, most recently from 769f37d to b5eccd9 Compare March 6, 2025 14:58

dfitzmau force-pushed the OCPBUGS-51174 branch from b5eccd9 to f09c8d7 Compare March 6, 2025 15:48

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2025

dfitzmau force-pushed the OCPBUGS-51174 branch 2 times, most recently from c087ec1 to 5a171ac Compare March 6, 2025 16:02

dfitzmau added branch/enterprise-4.12 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 labels Mar 6, 2025

dfitzmau force-pushed the OCPBUGS-51174 branch 7 times, most recently from ada3169 to 7c95b15 Compare March 7, 2025 12:51

kevin-anderson-redhat reviewed Mar 7, 2025

View reviewed changes

dfitzmau force-pushed the OCPBUGS-51174 branch from 7c95b15 to 8bb0255 Compare March 10, 2025 10:05

kevin-anderson-redhat reviewed Mar 10, 2025

View reviewed changes

modules/nw-cluster-mtu-change.adoc Outdated Show resolved Hide resolved

kevin-anderson-redhat reviewed Mar 10, 2025

View reviewed changes

modules/nw-cluster-mtu-change.adoc Outdated Show resolved Hide resolved

dfitzmau changed the title ~~OCPBUGS-55174: Updated the changing-cluster-network-mtu file with NIC…~~ OCPBUGS-51174: Updated the changing-cluster-network-mtu file with NIC… Mar 10, 2025

dfitzmau force-pushed the OCPBUGS-51174 branch from 8bb0255 to 4060f05 Compare March 10, 2025 11:45

dfitzmau added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 10, 2025

jldohmann added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 10, 2025

jldohmann reviewed Mar 10, 2025

View reviewed changes

jldohmann added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 10, 2025

jldohmann added this to the Continuous Release milestone Mar 10, 2025

OCPBUGS-55174: Updated the changing-cluster-network-mtu file with NIC…

d7d91b6

… info

dfitzmau force-pushed the OCPBUGS-51174 branch from 4060f05 to d7d91b6 Compare March 21, 2025 16:44

dfitzmau commented Mar 21, 2025

View reviewed changes

jcaamano reviewed Mar 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-51174: Updated the changing-cluster-network-mtu file with NIC… #89757

OCPBUGS-51174: Updated the changing-cluster-network-mtu file with NIC… #89757

dfitzmau commented Mar 6, 2025 •

edited

Loading

openshift-ci-robot commented Mar 6, 2025

openshift-ci-robot commented Mar 6, 2025

ocpdocs-previewbot commented Mar 6, 2025 •

edited

Loading

openshift-ci-robot commented Mar 6, 2025

kevin-anderson-redhat Mar 7, 2025

dfitzmau Mar 10, 2025

openshift-ci-robot commented Mar 10, 2025

kevin-anderson-redhat commented Mar 10, 2025

jldohmann left a comment

jldohmann Mar 10, 2025

dfitzmau Mar 18, 2025

dfitzmau commented Mar 11, 2025

anuragthehatter commented Mar 19, 2025

dfitzmau Mar 21, 2025

openshift-ci bot commented Mar 21, 2025

jcaamano Mar 28, 2025

jcaamano Mar 28, 2025

jcaamano Mar 28, 2025

dmc5179 Mar 28, 2025

jcaamano Mar 31, 2025

dfitzmau Mar 31, 2025

jcaamano Mar 28, 2025

OCPBUGS-51174: Updated the changing-cluster-network-mtu file with NIC… #89757

Are you sure you want to change the base?

OCPBUGS-51174: Updated the changing-cluster-network-mtu file with NIC… #89757

Conversation

dfitzmau commented Mar 6, 2025 • edited Loading

openshift-ci-robot commented Mar 6, 2025

openshift-ci-robot commented Mar 6, 2025

ocpdocs-previewbot commented Mar 6, 2025 • edited Loading

openshift-ci-robot commented Mar 6, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-ci-robot commented Mar 10, 2025

kevin-anderson-redhat commented Mar 10, 2025

jldohmann left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dfitzmau commented Mar 11, 2025

anuragthehatter commented Mar 19, 2025

Choose a reason for hiding this comment

openshift-ci bot commented Mar 21, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dfitzmau commented Mar 6, 2025 •

edited

Loading

ocpdocs-previewbot commented Mar 6, 2025 •

edited

Loading