Skip to content

OSDOCS-10810: Add additional routing capabilities #89983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

@jab-rh jab-rh added this to the Continuous Release milestone Mar 10, 2025
@jab-rh jab-rh self-assigned this Mar 10, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025

@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025

@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 10, 2025

🤖 Fri May 16 05:46:20 - Prow CI generated the docs preview:
https://89983--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@jab-rh jab-rh force-pushed the OSDOCS-10810-addn-routing branch 2 times, most recently from c1ec7d8 to 8c96069 Compare March 12, 2025 20:52
@jab-rh jab-rh force-pushed the OSDOCS-10810-addn-routing branch 2 times, most recently from 608132a to dfc4e6f Compare March 19, 2025 02:30
@jab-rh jab-rh force-pushed the OSDOCS-10810-addn-routing branch from dfc4e6f to 5d5de19 Compare March 27, 2025 00:54
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2025

@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.19,4.18.z

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.


:_mod-docs-content-type: CONCEPT
[id="nw-routeadvertisements-about_{context}"]
= Import and export pod network routes with Border Gateway Protocol

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this section, the title mentioned "Import", but the description only covered exporting route, need to add more description that external routes from provider network can be imported or learned into cluster

toc::[]

This feature provides route advertisement capabilities for the OVN-Kubernetes network plugin. A Border Gateway Router (BGP) provider is required. For more information, see xref:../../networking/bgp_routing/about-bgp-routing.adoc#about-bgp-routing[About BGP routing].

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this "About BGP routing" seems to have empty link, can you attach the link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jechen0648, this is broken because that content lives in a separate PR, and builds for this are unaware of that content. The link will work after that content is merged.

--

EgressIPs::
Supports the use of EgressIPs. The node where an egress IP address resides advertises the EgressIP. An egress IP address does not need to be on the same layer 2 network subnet as the egress node, because do not rely on gratuitous ARP (GARP).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

egressIP design has changed, with latest design, egressIP address still has to be one from same subnet of egress node


|`nodeSelector`
|`object`
|Optional: Limits the advertisements to selected nodes. When omitted, selects all nodes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcaamano But for nodeSelector on egressIP, it is the egress node that is selected by nodeSelector has its egressIP being advertised out. How to write this sentence correctly?

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 2, 2025

@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.19.z; 4.18.z

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 15, 2025
Copy link

openshift-ci bot commented May 16, 2025

@jab-rh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-portal e174699 link true /test validate-portal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants