-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-10810: Add additional routing capabilities #89983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Fri May 16 05:46:20 - Prow CI generated the docs preview: |
c1ec7d8
to
8c96069
Compare
608132a
to
dfc4e6f
Compare
dfc4e6f
to
5d5de19
Compare
@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
||
:_mod-docs-content-type: CONCEPT | ||
[id="nw-routeadvertisements-about_{context}"] | ||
= Import and export pod network routes with Border Gateway Protocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this section, the title mentioned "Import", but the description only covered exporting route, need to add more description that external routes from provider network can be imported or learned into cluster
toc::[] | ||
|
||
This feature provides route advertisement capabilities for the OVN-Kubernetes network plugin. A Border Gateway Router (BGP) provider is required. For more information, see xref:../../networking/bgp_routing/about-bgp-routing.adoc#about-bgp-routing[About BGP routing]. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this "About BGP routing" seems to have empty link, can you attach the link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jechen0648, this is broken because that content lives in a separate PR, and builds for this are unaware of that content. The link will work after that content is merged.
-- | ||
|
||
EgressIPs:: | ||
Supports the use of EgressIPs. The node where an egress IP address resides advertises the EgressIP. An egress IP address does not need to be on the same layer 2 network subnet as the egress node, because do not rely on gratuitous ARP (GARP). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
egressIP design has changed, with latest design, egressIP address still has to be one from same subnet of egress node
|
||
|`nodeSelector` | ||
|`object` | ||
|Optional: Limits the advertisements to selected nodes. When omitted, selects all nodes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcaamano But for nodeSelector on egressIP, it is the egress node that is selected by nodeSelector has its egressIP being advertised out. How to write this sentence correctly?
@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jab-rh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s): 4.19.z; 4.18.z
Issue:
Link to docs preview:
QE review:
Additional information: