Skip to content

OCPBUGS-49888: Adding update service connection prerequisite to TP st… #90640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

obrown1205
Copy link
Contributor

@obrown1205 obrown1205 commented Mar 19, 2025

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 19, 2025
@openshift-ci-robot
Copy link

@obrown1205: This pull request references Jira Issue OCPBUGS-49888, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
4.17+

Issue:
OCPBUGS-49888

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 19, 2025

@obrown1205 obrown1205 changed the title OCPBUGS-49888: Adding update service connection rperequisite to TP st… OCPBUGS-49888: Adding update service connection prerequisite to TP st… Mar 20, 2025
@@ -18,6 +18,10 @@ include::snippets/technology-preview.adoc[]
Your cluster does not need to be a Technology Preview-enabled cluster in order for you to use the `oc adm upgrade recommend` command.
====

.Prerequisites

* Your cluster is connected to an update service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could go either way on this. On the one hand, I think the OpenShift Update Service (whether it's the Red-Hat-hosted https://api.openshift.com/api/upgrades_info/graph or a customer-run OSUS) is a fantastic value-add, and think we should recommend it more strongly than we currently do. On the other hand, the recommend subcommand will not crash if there is no connected update service, it will just print a warning. So while it's not wrong that you'll want an Update Service to get much useful out of recommend, it shouldn't be terrible to skip that warning in the docs and expect customers who have intentionally-disabled or accidentally-broken Update Service access to figure out this relationship when they run the command. And I'd also be really excited if instead of pitching this as a prereq for this one command, we really pushed all customers towards having an Update Service feeding their cluster for all update-related commands, and explained to disconnected/restricted-network folks why we felt it was worth the trouble to run their own OSUS, to try and bring folks on board and emphasize what a value-add it is, instead of just having a low-context requirement they might feel grumbly about.

@jiajliu
Copy link

jiajliu commented Mar 21, 2025

@obrown1205 it seems the 1st part reemphasize the relationship between updating disconnected clusters using OSUS (Cincinnati) and using the regular update service (using a connected cluster) is not addressed in the pr, do we still need it for the bug https://issues.redhat.com/browse/OCPBUGS-49888?

@petr-muller
Copy link
Member

/cc

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2025
Copy link

openshift-ci bot commented Mar 26, 2025

@obrown1205: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@obrown1205
Copy link
Contributor Author

@obrown1205 it seems the 1st part reemphasize the relationship between updating disconnected clusters using OSUS (Cincinnati) and using the regular update service (using a connected cluster) is not addressed in the pr, do we still need it for the bug https://issues.redhat.com/browse/OCPBUGS-49888?

What do we think about https://docs.redhat.com/en/documentation/openshift_container_platform/4.14/html/updating_clusters/performing-a-cluster-update#update-service-overview_updating-restricted-network-cluster-osus? Do we want to add more to the section? @jiajliu

@jiajliu
Copy link

jiajliu commented Apr 8, 2025

What do we think about https://docs.redhat.com/en/documentation/openshift_container_platform/4.14/html/updating_clusters/performing-a-cluster-update#update-service-overview_updating-restricted-network-cluster-osus? Do we want to add more to the section? @jiajliu

The bug's description is a bit misleading. I thought you planned to improve it in this pr, so my original question was to confirm if this pr would include the issue mentioned in the bug. If it's not in the scope now, update-service-overview_updating-restricted-network-cluster-osus sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants