Skip to content

Follow-up edits to PR#8991, included corrective action window for new users #9105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ahardin-rh
Copy link
Contributor

@ahardin-rh ahardin-rh added this to the Next Release milestone May 8, 2018
@ahardin-rh ahardin-rh self-assigned this May 8, 2018
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 8, 2018
@abhgupta
Copy link
Member

abhgupta commented May 9, 2018

Feedback provided on IRC

@ahardin-rh ahardin-rh force-pushed the 8991-followup branch 2 times, most recently from 6952c1b to e47e0d2 Compare May 14, 2018 20:25
@ahardin-rh
Copy link
Contributor Author

@abhgupta Updated. PTAL.

@ahardin-rh
Copy link
Contributor Author

After discussion with @abhgupta , I am closing this. Although this PR holds correct information, we don't think the user needs to know the full complexity of the logic. The pertinent information that the user needs to know already exists and this would overly complicate things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants