Skip to content

Telcodocs 2124: Ensure NUMA Resources Operator Works on HyperShift Hosted Clusters #91162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Telcodocs 2124: Ensure NUMA Resources Operator Works on HyperShift Hosted Clusters #91162

wants to merge 1 commit into from

Conversation

kquinn1204
Copy link
Contributor

@kquinn1204 kquinn1204 commented Mar 27, 2025 •
edited
Loading

[TELCODOCS-2124]: Ensure NUMA Resources Operator Works on HyperShift Hosted Clusters

Version(s): 4.19

Issue: https://issues.redhat.com/browse/TELCODOCS-2124

Link to docs preview:

QE review: https://91162--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-numa-aware-scheduling.html#cnf-creating-nrop-cr-hosted-control-plane_numa-aware

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 27, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 27, 2025 •
edited
Loading

🤖 Thu Apr 24 13:32:58 - Prow CI generated the docs preview:

https://91162--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-numa-aware-scheduling.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Mar 27, 2025
View reviewed changes
modules/cnf-creating-nrop-cr-hosted-control-plane.adoc
@@ -0,0 +1,94 @@
// Module included in the following assemblies:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.ModuleContainsContentType: Module is missing the '_mod-docs-content-type' variable.

@kquinn1204 kquinn1204 changed the title Telcodocs 2124 Telcodocs 2124: Ensure NUMA Resources Operator Works on HyperShift Hosted Clusters Mar 27, 2025
@kquinn1204
Copy link
Contributor Author

@Tal-or @SargunNarula PTAL at this PR

Tal-or
Tal-or reviewed Apr 2, 2025
View reviewed changes
Copy link

@Tal-or Tal-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added few comments.
Also please make sure to specify that kubeletconfig should also be created in order to NUMA resources operator to function properly

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 2, 2025
@kquinn1204
Copy link
Contributor Author

@Tal-or I will get this merged first #91068 then add some links in this PR to show how to create PP for hosted clusater

@kquinn1204
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 22, 2025
@kquinn1204 kquinn1204 force-pushed the TELCODOCS-2124 branch 2 times, most recently from 6dbc12b to 0e47c8c Compare April 22, 2025 13:42
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 22, 2025
lahinson
lahinson reviewed Apr 22, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I posted a few comments for your consideration.

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.19 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 22, 2025
@kquinn1204
Copy link
Contributor Author

@SargunNarula when you have a few moments please review

@SargunNarula
Copy link

@kquinn1204 Thank you for your work on this. Please make sure to include a reference to #91068 for the kubelet config creation. Other than that, it looks good to me.

@kquinn1204
Copy link
Contributor Author

Great @SargunNarula I will make a reference to my other PR #91068

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 24, 2025

@kquinn1204: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tal-or Tal-or Tal-or left review comments

@lahinson lahinson lahinson left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.19 GA
Development

Successfully merging this pull request may close these issues.
6 participants
@kquinn1204 @ocpdocs-previewbot @SargunNarula @Tal-or @lahinson @ocpdocs-vale-bot