Skip to content

OSDOCS-12143#Migrating CNS vols between datastores for vSphere #91478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

OSDOCS-12143#Migrating CNS vols between datastores for vSphere #91478

merged 1 commit into from
May 16, 2025

Conversation

lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Apr 1, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 1, 2025
@lpettyjo lpettyjo added branch/enterprise-4.19 peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 1, 2025
@lpettyjo lpettyjo added this to the Planned for 4.19 GA milestone Apr 1, 2025
@lpettyjo lpettyjo requested a review from gnufied April 1, 2025 20:35
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 1, 2025 •
edited
Loading

🤖 Wed May 14 17:24:27 - Prow CI generated the docs preview:

https://91478--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-vsphere.html

@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 2, 2025
xenolinux
xenolinux reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a change; lgtm overall

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 2, 2025
@gnufied
Copy link
Member

gnufied commented May 13, 2025 •
edited
Loading

minor nit

@lpettyjo
Copy link
Contributor Author

minor nit

Am I missing something? I don't see what the "minor nit" is. Is there another comment somewhere?

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 14, 2025

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gnufied
Copy link
Member

gnufied commented May 14, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@duanwei33
Copy link

@radeore Could you please take a look on this?

@radeore
Copy link

radeore commented May 16, 2025

LGTM

@gcharot
Copy link

gcharot commented May 16, 2025

/lgtm

@lpettyjo lpettyjo merged commit 434e4b8 into openshift:main May 16, 2025
2 checks passed
@lpettyjo
Copy link
Contributor Author

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

@lpettyjo: new pull request created: #93503

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@gcharot gcharot gcharot left review comments

@xenolinux xenolinux xenolinux left review comments

Assignees

@gnufied gnufied

@gcharot gcharot

Labels
branch/enterprise-4.19 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.19 GA
Development

Successfully merging this pull request may close these issues.
8 participants
@lpettyjo @ocpdocs-previewbot @gnufied @duanwei33 @radeore @gcharot @openshift-cherrypick-robot @xenolinux