Skip to content

OCPBUGS-48479: Adding MHC exception to Pausing MHC cluster update … #91781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-48479: Adding MHC exception to Pausing MHC cluster update … #91781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion modules/machine-health-checks-pausing.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@
[id="machine-health-checks-pausing_{context}"]
= Pausing a MachineHealthCheck resource

During the update process, nodes in the cluster might become temporarily unavailable. In the case of worker nodes, the machine health check might identify such nodes as unhealthy and reboot them. To avoid rebooting such nodes, pause all the `MachineHealthCheck` resources before updating the cluster.
During the update process, nodes in the cluster might become temporarily unavailable. In the case of worker nodes, the MachineHealthCheck resources might identify such nodes as unhealthy and reboot them. To avoid rebooting such nodes, pause all the `MachineHealthCheck` resources before updating the cluster.

[NOTE]
====
Some MachineHealthChecks might not need to be paused. If your MachineHealthCheck (MHC) resource has a fatal condition met, new nodes cannot be deployed, and pausing that MHC is unnecessary.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.TermsErrors: Use 'unrecoverable' rather than 'fatal'. For more information, see RedHat.TermsErrors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe just drop "new nodes cannot be deployed", because it's not about new Nodes watched by the MHC, it's about the Node that the MHC is sad about being terminal. Maybe something like:

If your MachineHealthCheck (MHC) resource relies on unrecoverable conditions, pausing that MHC is unnecessary.

====

.Prerequisites

Expand Down