Skip to content

Conversation

@skopacz1
Copy link
Contributor

@skopacz1 skopacz1 commented Apr 8, 2025

OSDOCS-13618

Version(s): 4.17+

This PR adds a prerequisite to the procedures for adding nodes to on-prem clusters.

QE review:

  • QE has approved this change.

Previews:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025

@skopacz1: This pull request references OSDOCS-13618 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

OSDOCS-13618

Version(s): 4.17+

This PR adds a prerequisite to the procedures for adding

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025

@skopacz1: This pull request references OSDOCS-13618 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

OSDOCS-13618

Version(s): 4.17+

This PR adds a prerequisite to the procedures for adding nodes to on-prem clusters.

QE review:

  • QE has approved this change.

Previews:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@skopacz1 skopacz1 changed the title OSDOCS-13618: adding rsync prereq OSDOCS#13618: adding rsync prereq Apr 8, 2025
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 8, 2025
@openshift-ci-robot
Copy link

@skopacz1: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

OSDOCS-13618

Version(s): 4.17+

This PR adds a prerequisite to the procedures for adding nodes to on-prem clusters.

QE review:

  • QE has approved this change.

Previews:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

🤖 Tue Apr 08 19:55:58 - Prow CI generated the docs preview:

https://91894--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/nodes/nodes-nodes-adding-node-iso.html

@openshift-ci
Copy link

openshift-ci bot commented Apr 8, 2025

@skopacz1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andfasano
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
@fkawakubo
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 9, 2025

@fkawakubo: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mhanss
Copy link

mhanss commented Jun 3, 2025

/lgtm

@skopacz1 skopacz1 added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 3, 2025
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 3, 2025
@mburke5678
Copy link
Contributor

/lgtm

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 3, 2025
@skopacz1 skopacz1 merged commit b038d09 into openshift:main Jun 3, 2025
2 checks passed
@skopacz1
Copy link
Contributor Author

skopacz1 commented Jun 3, 2025

/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19

@openshift-cherrypick-robot

@skopacz1: new pull request created: #94186

Details

In response to this:

/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@skopacz1: new pull request created: #94189

Details

In response to this:

/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@skopacz1: new pull request created: #94190

Details

In response to this:

/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants