Skip to content

OCPBUGS#52836: sysType needs to be a property of controlPlane.platform.powervs and compute.platform.powervs #91901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xenolinux merged 1 commit into from
Jun 6, 2025
Merged

OCPBUGS#52836: sysType needs to be a property of controlPlane.platform.powervs and compute.platform.powervs #91901

xenolinux merged 1 commit into from
Jun 6, 2025

Conversation

@alishaIBM
Copy link
Contributor

@alishaIBM alishaIBM commented Apr 9, 2025 •
edited by xenolinux
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 9, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 9, 2025 •
edited
Loading

🤖 Fri Jun 06 06:05:28 - Prow CI generated the docs preview:
https://91901--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2025
@AshwinHIBM
Copy link

AshwinHIBM commented Apr 17, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2025
@alishaIBM
Copy link
Contributor Author

alishaIBM commented Apr 23, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 23, 2025
@aravipra
Copy link
Contributor

aravipra commented Apr 23, 2025

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 23, 2025
aravipra
aravipra reviewed Apr 23, 2025
View reviewed changes
aravipra
aravipra reviewed Apr 23, 2025
View reviewed changes
@aravipra
Copy link
Contributor

aravipra commented Apr 23, 2025

I left some comments for review, but please wait until @agantony approves my review before implementing any feedback.

@aravipra
Copy link
Contributor

aravipra commented Apr 23, 2025

/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 23, 2025
@aravipra
Copy link
Contributor

aravipra commented Apr 23, 2025

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 23, 2025
@aravipra
Copy link
Contributor

aravipra commented Apr 23, 2025

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Apr 23, 2025
@agantony
Copy link
Contributor

agantony commented Apr 23, 2025

I left some comments for review, but please wait until @agantony approves my review before implementing any feedback.

LGTM

@alishaIBM
Copy link
Contributor Author

alishaIBM commented May 22, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 22, 2025
@jab-rh
Copy link
Contributor

jab-rh commented May 22, 2025

@alishaIBM, can you squash the commits in this PR please? Thanks!

@ShaunaDiaz ShaunaDiaz removed the merge-review-needed Signifies that the merge review team needs to review this PR label May 22, 2025
@ShaunaDiaz
Copy link
Contributor

ShaunaDiaz commented May 22, 2025

@alishaIBM You'll need to please 1) check the box if you have QE ack; 2) get a SME approval; 3) squash the commits to 1 prior to merge; and 4) address the peer review comments (fix or resolve in some way).

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 5, 2025

New changes are detected. LGTM label has been removed.

@alishaIBM
Copy link
Contributor Author

alishaIBM commented Jun 5, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 5, 2025
@ShaunaDiaz
Copy link
Contributor

ShaunaDiaz commented Jun 5, 2025

@alishaIBM I see a QE ack, but we're still missing an engineering ack, looks like.

@alishaIBM
Copy link
Contributor Author

alishaIBM commented Jun 5, 2025

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jun 5, 2025

@alishaIBM: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ShaunaDiaz
Copy link
Contributor

ShaunaDiaz commented Jun 5, 2025

@gpei Please LGTM or provide corrections? TY!

@ShaunaDiaz ShaunaDiaz added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 5, 2025
@gpei
Copy link

gpei commented Jun 6, 2025

@ShaunaDiaz Hi, could you please find PowerVS QE to ack this? I remember this was [email protected] before

@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2025

@alishaIBM: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sonia-garudi
Copy link

sonia-garudi commented Jun 6, 2025

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2025

@sonia-garudi: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alishaIBM
Copy link
Contributor Author

alishaIBM commented Jun 6, 2025

@ShaunaDiaz Hi, could you please find PowerVS QE to ack this? I remember this was [email protected] before

@gpei we now have the QE approval. Thanks.

@alishaIBM
Copy link
Contributor Author

alishaIBM commented Jun 6, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 6, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 6, 2025
@xenolinux xenolinux added this to the Planned for 4.19 GA milestone Jun 6, 2025
xenolinux
xenolinux reviewed Jun 6, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good!

General suggestions:

  • Remove do-not-merge/hold label before submitting the PR for merging.

  • Please follow this format for the PR title: OCPBUGS#12345: Fix the title
    Use # in the PR title instead of dash -- for example, OCPBUGS#12345: Fix the title to avoid Jira comments.

@xenolinux xenolinux changed the title sysType needs to be a property of controlPlane.platform.powervs and c… OCPBUGS#52836: sysType needs to be a property of controlPlane.platform.powervs and ompute.platform.powervs Jun 6, 2025
@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 6, 2025
@xenolinux xenolinux merged commit f1733e5 into openshift:main Jun 6, 2025
2 checks passed
@xenolinux
Copy link
Contributor

xenolinux commented Jun 6, 2025

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 6, 2025

@xenolinux: new pull request created: #94376

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 6, 2025
Merged
@xenolinux xenolinux changed the title OCPBUGS#52836: sysType needs to be a property of controlPlane.platform.powervs and ompute.platform.powervs OCPBUGS#52836: sysType needs to be a property of controlPlane.platform.powervs and compute.platform.powervs Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

+1 more reviewer

@aravipra aravipra aravipra left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@AshwinHIBM AshwinHIBM

Labels

branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Planned for 4.19 GA

Development

Successfully merging this pull request may close these issues.