Skip to content

OCPBUGS-54909: Add multicast snooping #92115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OCPBUGS-54909: Add multicast snooping #92115

wants to merge 2 commits into from

Conversation

jab-rh
Copy link
Contributor

@jab-rh jab-rh commented Apr 11, 2025 •
edited
Loading

Version(s): 4.16+

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@jab-rh jab-rh added this to the Continuous Release milestone Apr 11, 2025
@jab-rh jab-rh self-assigned this Apr 11, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 11, 2025
@openshift-ci-robot
Copy link

@jab-rh: This pull request references Jira Issue OCPBUGS-54909, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s): 4.16+

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 11, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 11, 2025 •
edited
Loading

🤖 Fri Apr 18 00:26:40 - Prow CI generated the docs preview:

https://92115--ocpdocs-pr.netlify.app/
https://92115--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/ipi/ipi-install-installation-workflow.html
https://92115--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/ipi/ipi-install-post-installation-configuration.html
https://92115--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/upi/installing-bare-metal.html
https://92115--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/upi/installing-bare-metal-network-customizations.html
https://92115--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/upi/installing-restricted-networks-bare-metal.html
https://92115--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/secondary_networks/creating-secondary-nwt-ovnk.html

@zhaozhanqi
Copy link

The changes looks good

# ovs-vsctl get bridge ovs-br1 mcast_snooping_enable
true

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@jab-rh jab-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 16, 2025
@shreyasiddhartha
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 16, 2025
shreyasiddhartha
shreyasiddhartha reviewed Apr 16, 2025
View reviewed changes
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Provided a few nits to improve writing suggestions for callouts in code blocks.

@xenolinux PTAL! Thanks. :)

xenolinux
xenolinux reviewed Apr 16, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up peer review:
@shreyasiddhartha @jab-rh One comment #92115 (comment)

Overall LGTM!

@shreyasiddhartha
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 16, 2025
@jab-rh
Copy link
Contributor Author

jab-rh commented Apr 17, 2025

@shreyasiddhartha thanks!

@jab-rh @shreyasiddhartha
Apply suggestions from code review
d521616 
Co-authored-by: Shreya Siddhartha <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 17, 2025

New changes are detected. LGTM label has been removed.

@jab-rh
Copy link
Contributor Author

jab-rh commented Apr 18, 2025

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 18, 2025

@jab-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

@shreyasiddhartha shreyasiddhartha shreyasiddhartha left review comments

Assignees

@zhaozhanqi zhaozhanqi

@jab-rh jab-rh

Labels
branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@jab-rh @openshift-ci-robot @ocpdocs-previewbot @zhaozhanqi @shreyasiddhartha @xenolinux