-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS#14025: Removing note saying that modern profile isn't supporte… #92144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
83c95b5
to
cced86d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Looks like we need to update the following to include the modern option as well.
|
…d for control plane
cced86d
to
c5dcce8
Compare
@gangwgr I know the eng PR isn't merged yet, but here is the docs PR for TLS 1.3/modern profile for control plane. Can you PTAL when you get a chance? (I'll make sure the eng PR merges before merging this) @dusk125 noticed that we needed to add modern as an option below the example, but I also see that we didn't have it listed for the ingress controller and kubelet. So I've added it there, because I'm pretty certain it's supported for those. Let me know if this is something you can help confirm, or if we need to pull in someone else to help with that. Thanks! Previews:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Preview regeneration seems stuck. Prow jobs look to be backed up, so I don't think retesting will do anything other than putting us farther down in the queue. Will check back in later. Edit: all good now |
/retest |
@bergerhoffer: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…d for control plane
Version(s):
4.19
Issue:
https://issues.redhat.com/browse/OSDOCS-14025
Link to docs preview:
QE review:
Additional information:
Do not merge this until the eng PR merges