Skip to content

OSDOCS#14025: Removing note saying that modern profile isn't supporte… #92144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Apr 14, 2025

@bergerhoffer bergerhoffer added this to the Planned for 4.19 GA milestone Apr 14, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 14, 2025
@bergerhoffer
Copy link
Contributor Author

@jacobsee @dusk125 Can you PTAL? (I won't merge until we're sure the eng PR makes it)

Copy link

@dusk125 dusk125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2025
@dusk125
Copy link

dusk125 commented Apr 16, 2025

Looks like we need to update the following to include the modern option as well.
Step 2 of the procedure for configuring control plane in modules/tls-profiles-kubernetes-configuring.adoc

<1> Specify the TLS security profile type (`Old`, `Intermediate`, or `Custom`). The default is `Intermediate`.
<2> Specify the appropriate field for the selected type:
* `old: {}`
* `intermediate: {}`
* `custom:`
<3> For the `custom` type, specify a list of TLS ciphers and minimum accepted TLS version.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2025
@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Apr 16, 2025

@gangwgr I know the eng PR isn't merged yet, but here is the docs PR for TLS 1.3/modern profile for control plane. Can you PTAL when you get a chance? (I'll make sure the eng PR merges before merging this)

@dusk125 noticed that we needed to add modern as an option below the example, but I also see that we didn't have it listed for the ingress controller and kubelet. So I've added it there, because I'm pretty certain it's supported for those. Let me know if this is something you can help confirm, or if we need to pull in someone else to help with that. Thanks!

Previews:

Copy link

@dusk125 dusk125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2025
@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Apr 16, 2025

Preview regeneration seems stuck. Prow jobs look to be backed up, so I don't think retesting will do anything other than putting us farther down in the queue. Will check back in later.

Edit: all good now

@bergerhoffer
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Apr 16, 2025

@bergerhoffer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.19 lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants