Skip to content

OCPBUGS-55069:updates RBAC for UDN #92273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoeAldinger
Copy link
Contributor

@JoeAldinger JoeAldinger commented Apr 16, 2025

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 16, 2025
@openshift-ci-robot
Copy link

@JoeAldinger: This pull request references Jira Issue OCPBUGS-55069, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
4.17+

Issue:
https://issues.redhat.com/browse/OCPBUGS-55069

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoeAldinger JoeAldinger added branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Apr 16, 2025
@JoeAldinger JoeAldinger added this to the Continuous Release milestone Apr 16, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 16, 2025
//====
.Perquisites

* You have logged in with `cluster-admin` privileges, or you have `view` and `edit` role-based access control (RBAC).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can squeeze this somehow here admin or view & edit roles in the subject namespace. ?

Copy link
Contributor Author

@JoeAldinger JoeAldinger Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason I didn't add the namespace specificity is because the first step of creating a UDN is to create a namespace so I thought we were covered. Also, all of those roles would be able to create namespaces.

@JoeAldinger
Copy link
Contributor Author

/retest

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 16, 2025

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 16, 2025
@openshift-ci-robot
Copy link

@JoeAldinger: This pull request references Jira Issue OCPBUGS-55069, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.17+

Issue:
https://issues.redhat.com/browse/OCPBUGS-55069

Link to docs preview:
https://92273--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/primary_networks/about-user-defined-networks.html#nw-udn-cr_about-user-defined-networks:~:text=Perquisites-,You,-have%20logged%20in

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoeAldinger
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Apr 17, 2025

@JoeAldinger: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants