-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS-55069:updates RBAC for UDN #92273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@JoeAldinger: This pull request references Jira Issue OCPBUGS-55069, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
//==== | ||
.Perquisites | ||
|
||
* You have logged in with `cluster-admin` privileges, or you have `view` and `edit` role-based access control (RBAC). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can squeeze this somehow here admin or view & edit roles in the subject namespace.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only reason I didn't add the namespace specificity is because the first step of creating a UDN is to create a namespace so I thought we were covered. Also, all of those roles would be able to create namespaces.
/retest |
🤖 Thu Apr 17 12:43:19 - Prow CI generated the docs preview: |
@JoeAldinger: This pull request references Jira Issue OCPBUGS-55069, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
@JoeAldinger: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s):
4.17+
Issue:
https://issues.redhat.com/browse/OCPBUGS-55069
Link to docs preview:
https://92273--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/primary_networks/about-user-defined-networks.html#nw-udn-cr_about-user-defined-networks:~:text=Perquisites-,You,-have%20logged%20in
QE review:
Additional information: