OCPBUGS-55123: Fix apiVersion in compute machine set specs

[jeana-redhat]

Version(s):
4.12+

Issue:
OCPBUGS-55123

Link to docs preview:

• Sample YAML for a compute machine set custom resource on Azure (infra)
• Sample YAML for a compute machine set custom resource on GCP (infra)
• Sample YAML for a compute machine set custom resource on vSphere (infra)
• Sample YAML for a compute machine set custom resource on Azure
• Sample YAML for a compute machine set custom resource on GCP
• Sample YAML for a compute machine set custom resource on vSphere
• Adding a multi-architecture compute machine set to your GCP cluster
• Sample YAML for a Windows MachineSet object on Azure
• Sample YAML for a Windows MachineSet object on vSphere

QE review:

• QE has approved this change.

Additional information:

[openshift-ci-robot]

@jeana-redhat: This pull request references Jira Issue OCPBUGS-55123, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @huali9

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
4.12+

Issue:
OCPBUGS-55123

Link to docs preview:
🚧

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ocpdocs-previewbot]

🤖 Thu Apr 17 18:05:24 - Prow CI generated the docs preview:

https://92348--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/creating-infrastructure-machinesets.html
https://92348--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/creating_machinesets/creating-machineset-azure.html
https://92348--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/creating_machinesets/creating-machineset-gcp.html
https://92348--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/creating_machinesets/creating-machineset-vsphere.html
https://92348--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/configuring-multi-arch-compute-machines/creating-multi-arch-compute-nodes-gcp.html
https://92348--ocpdocs-pr.netlify.app/openshift-enterprise/latest/windows_containers/creating_windows_machinesets/creating-windows-machineset-azure.html
https://92348--ocpdocs-pr.netlify.app/openshift-enterprise/latest/windows_containers/creating_windows_machinesets/creating-windows-machineset-vsphere.html

[openshift-ci]

@jeana-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jeana-redhat: This pull request references Jira Issue OCPBUGS-55123, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @huali9

In response to this:

Version(s):
4.12+

Issue:
OCPBUGS-55123

Link to docs preview:

• https://92348--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/creating-infrastructure-machinesets.html
• https://92348--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/creating_machinesets/creating-machineset-azure.html
• https://92348--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/creating_machinesets/creating-machineset-gcp.html
• https://92348--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/creating_machinesets/creating-machineset-vsphere.html
• https://92348--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/configuring-multi-arch-compute-machines/creating-multi-arch-compute-nodes-gcp.html
• https://92348--ocpdocs-pr.netlify.app/openshift-enterprise/latest/windows_containers/creating_windows_machinesets/creating-windows-machineset-azure.html
• https://92348--ocpdocs-pr.netlify.app/openshift-enterprise/latest/windows_containers/creating_windows_machinesets/creating-windows-machineset-vsphere.html

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jeana-redhat]

@huali9 a global search to fix these turned up some instances in WinC and Multiarch. If those cases are outside your scope, let me know 🙂

[huali9]

Hi @jeana-redhat
Although I think WinC and Multiarch instances should be the same with normal instances in that respect(apiVersion), because in our CI I can see that they are all copied from a default worker machineset and then update some specific settings. For example: https://github.com/openshift/release/blob/master/ci-operator/step-registry/ipi/conf/vsphere/windows-machineset/ipi-conf-vsphere-windows-machineset-commands.sh#L23-L41
https://github.com/openshift/release/blob/master/ci-operator/step-registry/ipi/install/heterogeneous/ipi-install-heterogeneous-commands.sh#L195-L202 and https://github.com/openshift/release/blob/master/ci-operator/step-registry/ipi/install/heterogeneous/ipi-install-heterogeneous-commands.sh#L315-L317

But I think we'd better not touch WinC and Multiarch part, because we don't create WinC and Multiarch machines by default, and both apiVersion work. In addition, if we change it, I see another inconsistency in WinC and Multiarch part, like https://drive.google.com/file/d/1LqJUE8aOPAc4cwU4WE2I4o2XUsc_nWqs/view?usp=sharing and https://drive.google.com/file/d/17B_vep3X3r3yYqlrMT0HCspLy1y7yRua/view?usp=sharing
and I'm not sure if there are other inconsistencies.

Version(s):
4.12+

For versions, I am not sure from which OCP version the apiVersion was changed, but I'm sure it's machine.openshift.io/v1beta1 since 4.16, so I suggest 4.16+, what do you think?