Docs for MCO-836 [GA] Machine Config Node #92503
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/M
|
🤖 Thu May 08 11:33:46 - Prow CI generated the docs preview: https://92503--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_configuration/index.html |
openshift-ci
bot
added
size/L
|
@isabella-janssen PTAL |
|
I still see a description here talking about custom MCPs not being supported. I think that needs to be updated as well. |
| ** *ReloadedCRIO* | ||
| * *NodeDegraded* The node update failed. You can view the reason for the failure by using the `oc describe machineconfignode` command, as described later in this section. | ||
| * *Update Post update action* The MCO reloads CRI-O, as needed. | ||
| * *Rebooted Node* The MCO reboots the node, as needed. | ||
| * *Update Complete*. The MCO uncordons the nodes, updates the node state to the cluster, and resumes producing node metrics. |
There was a problem hiding this comment.
Suggested change
| * *Update Complete*. The MCO uncordons the nodes, updates the node state to the cluster, and resumes producing node metrics. | |
| * *Update Complete*. The MCO uncordons the nodes, updates the node state to the cluster, and resumes producing node metrics. It contains the following sub-phase: |
Suggestion: Add the It contains the following sub-phase: phrase to be consistent with how the Update Executed bullet was written.
|
@ptalgulk01 PTAL |
ptalgulk01
suggested changes
May 7, 2025
| @@ -6,37 +6,31 @@ | |||
| [id="checking-mco-node-status_{context}"] | |||
| = About checking machine config node status | |||
|
|
|||
| If you make changes to the default control plane or worker nodes in your cluster, for example by using a machine config or kubelet config, you can get detailed information about the progress of the node updates by using the machine config nodes custom resource. Any change that results in a new machine config triggers the node update process. | |||
| If you make changes to the to a machine config pool that results in a new machine config, for example by using a machine config or kubelet config, you can get detailed information about the progress of the node updates by using the machine config nodes custom resource. | |||
There was a problem hiding this comment.
There is typo here between to the / to a
mburke5678
force-pushed
the
mco-machine-config-node-419
branch
2 times, most recently
from
38b2824 to
fe56b4d
Compare
mburke5678
added
the
peer-review-needed
|
/remove-label peer-review-needed |
openshift-ci
bot
added
peer-review-in-progress
kowen-rh
suggested changes
May 7, 2025
| ** *Updated* | ||
| * *NodeDegraded* The node update failed. You can view the reason for the failure by using the `oc describe machineconfignode` command, as described later in this section. | ||
| * *Update Post update action* The MCO is reloading CRI-O, as needed. | ||
| * *Rebooted Node* The is MCO rebooting the node, as needed. |
There was a problem hiding this comment.
Typo: "The is MCO" should be "The MCO is".
| @@ -6,37 +6,31 @@ | |||
| [id="checking-mco-node-status_{context}"] | |||
| = About checking machine config node status | |||
|
|
|||
| If you make changes to the default control plane or worker nodes in your cluster, for example by using a machine config or kubelet config, you can get detailed information about the progress of the node updates by using the machine config nodes custom resource. Any change that results in a new machine config triggers the node update process. | |||
| If you make changes to a machine config pool that results in a new machine config, for example by using a `MachineConfig` or `KubeletConfig` object, you can get detailed information about the progress of the node updates by using the machine config nodes custom resource. | |||
There was a problem hiding this comment.
Should we also introduce the "MCP" acronym here?
openshift-ci
bot
added
peer-review-done
mburke5678
force-pushed
the
mco-machine-config-node-419
branch
from
fe56b4d to
8ea5d64
Compare
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This looks great to me, many thanks @mburke5678 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/OSDOCS-14404
Updates needed
Previews:
About checking machine config node status:
oc get machineconfignode -o widecommand to remove theUPDATECOMPATIBLEandRELOADEDCRIOcolumns;oc describe machineconfignode/<machine_config_node_name> -o yamlcommand.Checking machine config node status:
oc get machineconfignodescommand;oc get machineconfignode -o widecommand to remove theUPDATECOMPATIBLEandRELOADEDCRIOcolumns;oc describe machineconfignode/<node_name>command.QE review: