-
Notifications
You must be signed in to change notification settings - Fork 1.8k
<do-not-merge> RHDEVDOCS-6444: Content creation for GitOps 1.15.2 #92626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gitops-docs-1.15
Are you sure you want to change the base?
<do-not-merge> RHDEVDOCS-6444: Content creation for GitOps 1.15.2 #92626
Conversation
@Dhruv-Soni11: This pull request references RHDEVDOCS-6444 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Fri May 16 07:02:15 - Prow CI generated the docs preview: https://92626--ocpdocs-pr.netlify.app/ |
/retest |
db334e1
to
5b57240
Compare
@Dhruv-Soni11: This pull request references RHDEVDOCS-6444 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-6444 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
@Dhruv-Soni11 please add RN from https://issues.redhat.com/browse/GITOPS-6150 once its available |
https://issues.redhat.com/browse/GITOPS-6150 RN is available, you can add it @Dhruv-Soni11, apologies, I missed mentioning this ticket before, and thanks Varsha for pointing out |
LGTM, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/label peer-review-needed |
@Dhruv-Soni11 A few comments. Otherwise LGTM |
3b775b0
to
52f77be
Compare
/label merge-review-needed |
@Dhruv-Soni11: This pull request references RHDEVDOCS-6444 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-6444 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11 Had a couple of comments before merge. Probably wouldn't have held up the merge over these issues. But, where we are not merging yet, maybe you could take a look. When it comes time to merge, let me know and we can avoid wasting the time of another merge reviewer over these two issues. |
Thanks for performing a quick merge review on this PR, @mburke5678. I have fixed a couple of your comments and am waiting for further instructions from the QE and SME team to add the errata details. Once I get those details, I will update this PR and tag you for merge review. Thanks for the quick comments and suggestions. |
Fixed QE review comments Incorporating SME review comments
c7d7094
to
4b8ad91
Compare
@Dhruv-Soni11: This pull request references RHDEVDOCS-6444 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-6444 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-6444 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Version(s):
gitops-docs-1.15, gitops-docs-1.16, gitops-docs-main
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-6444
Link to docs preview:
Release Notes for GitOps v1.15.2
QE review:
SME review: @Rizwana777, [email protected], [email protected], [email protected]
QE review: @varshab1210
Peer review: @mburke5678
Additional information:
Kindly perform the merge review as per the normal steps, but do not merge the PR if everything looks fine, as the SME/QE team might provide us with an additional release note.