-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[enterprise-4.19] Add release note for BGP routing #92974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enterprise-4.19
Are you sure you want to change the base?
Conversation
🤖 Thu May 15 17:53:52 - Prow CI generated the docs preview: |
Identical steps confirmed by QE: #88826 (comment) |
/remove-label peer-review-needed /label peer-review-in-progress |
Hello @jab-rh there seems to be an issue with the xref (link to logs), can you fix this so that the tests are succesful and the content therefore ready for review? Thanks! (I will publish my review once the issue is fixed. ) |
@eromanova97, I've fixed the build, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I have finished my review.
Note to squash the commits before asking for merge.
Thank you!
[id="ocp-4-19-support-for-bgp-routing-protocol_{context}"] | ||
==== Support for the BGP routing protocol | ||
|
||
The Cluster Network Operator (CNO) now supports enabling Border Gateway Protocol (BGP) routing. With BGP, you can import and export routes to the underlying provider network and utilize multi-homing, link redundancy, and fast convergence. BGP configuration is managed with the `FRRConfiguration` custom resource (CR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Cluster Network Operator (CNO) now supports enabling Border Gateway Protocol (BGP) routing. With BGP, you can import and export routes to the underlying provider network and utilize multi-homing, link redundancy, and fast convergence. BGP configuration is managed with the `FRRConfiguration` custom resource (CR). | |
The Cluster Network Operator (CNO) now supports enabling Border Gateway Protocol (BGP) routing. With BGP, you can import and export routes to the underlying provider network and utilize multi-homing, link redundancy, and fast convergence. You can manage BGP configuration with the `FRRConfiguration` custom resource (CR). |
To get rid of passive voice.
|
||
The Cluster Network Operator (CNO) now supports enabling Border Gateway Protocol (BGP) routing. With BGP, you can import and export routes to the underlying provider network and utilize multi-homing, link redundancy, and fast convergence. BGP configuration is managed with the `FRRConfiguration` custom resource (CR). | ||
|
||
When upgrading from an earlier version of {product-title} with the Metal LB Operator deployed, you must manually migrate your custom frr-k8s configurations from the `metallb-system` namespace to the `openshift-frr-k8s` namespace. To move these CRs, enter the following commands: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When upgrading from an earlier version of {product-title} with the Metal LB Operator deployed, you must manually migrate your custom frr-k8s configurations from the `metallb-system` namespace to the `openshift-frr-k8s` namespace. To move these CRs, enter the following commands: | |
When upgrading from an earlier version of {product-title} with the Metal LB Operator deployed, you must manually migrate your custom `FRR-K8s` configurations from the `metallb-system` namespace to the `openshift-frr-k8s` namespace. To move these CRs, enter the following commands: |
In the docs (link) I see it capitalised like this FRR-K8s
:
`MetalLB` generates the `FRR-K8s` configuration corresponding to...
oc get frrconfigurations.frrk8s.metallb.io -n "${OLD_NAMESPACE}" -o json |\ | ||
jq -r '.items[] | select(.metadata.name | test("'"${FILTER_OUT}"'") | not)' |\ | ||
jq -r '.metadata.namespace = "'"${NEW_NAMESPACE}"'"' |\ | ||
oc create -f - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A note about the usage of jq
: https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#commands-with-jq
Do not use jq in commands (unless it is truly required) ...
here it looks like it is truly required, but I am checking just in case.
$ oc get frrconfigurations.frrk8s.metallb.io -n openshift-frr-k8s | ||
---- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a possible Example output to show?
https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#code-blocks-command-syntax-and-example-output
Or, if that would be too long, maybe just adding a sentence about what the user should see?
/remove-label peer-review-in-progress /label peer-review-done |
c0b6f71
to
7165210
Compare
7165210
to
41f61f8
Compare
@jab-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s): 4.19
Issue:
Link to docs preview:
Support for the BGP routing protocol
QE review:
Additional information:
Refs #88842 & #88826
Build fails until the feature PR is merged, then the
xref
becomes valid.