Skip to content

OSDOCS-14169:CUDN localnet #93001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JoeAldinger
Copy link
Contributor

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2025

@JoeAldinger: This pull request references OSDOCS-14169 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 5, 2025
@JoeAldinger JoeAldinger added this to the Planned for 4.19 GA milestone May 5, 2025
@JoeAldinger JoeAldinger force-pushed the OSDOCS-14169 branch 3 times, most recently from 3dfa1ea to db8dd9b Compare May 5, 2025 20:01
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2025
@JoeAldinger JoeAldinger force-pushed the OSDOCS-14169 branch 3 times, most recently from 4fb867f to 4ce05fd Compare May 14, 2025 15:51
Copy link

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some copy / paste errors from the L2 part IIUC.

And I think we can make the text more straight-forward in a couple places.

<6> The `topology` field describes the network configuration; accepted values are `Layer2`, `Layer3`, and `Localnet`. Specifying a `Localnet` topology type creates one logical switch that is shared by all nodes.
<7> This field specifies the topology configuration. It can be `layer2` or `layer3`.
<8> Specifies `Primary` or `Secondary`. `Primary` is the only `role` specification supported in {product-version}.
<9> For `Layer2` topology types the following specifies config details for the `subnet` field:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to refer Localnet instead of Layer2.


* You have logged in as a user with `cluster-admin` privileges.

* You have created and configured the Open vSwitch (OVS) bridge mapping to associate the physical network with the interface label created by OVS. For more information, see "Configuration for a localnet switched topology".
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this more confusing than it needs to - especially the "interface label" part.

What do we even mean w/ that ? The purpose of the bridge mappings is to associate the logical network (OVN) with a physical Kubernetes node interface via an OVS bridge (to which said interface is connected to).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote this to try to clarify.

Copy link

openshift-ci bot commented May 16, 2025

@JoeAldinger: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants