-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-14169:CUDN localnet #93001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OSDOCS-14169:CUDN localnet #93001
Conversation
@JoeAldinger: This pull request references OSDOCS-14169 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3dfa1ea
to
db8dd9b
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4fb867f
to
4ce05fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some copy / paste errors from the L2 part IIUC.
And I think we can make the text more straight-forward in a couple places.
modules/nw-cudn-localnet.adoc
Outdated
<6> The `topology` field describes the network configuration; accepted values are `Layer2`, `Layer3`, and `Localnet`. Specifying a `Localnet` topology type creates one logical switch that is shared by all nodes. | ||
<7> This field specifies the topology configuration. It can be `layer2` or `layer3`. | ||
<8> Specifies `Primary` or `Secondary`. `Primary` is the only `role` specification supported in {product-version}. | ||
<9> For `Layer2` topology types the following specifies config details for the `subnet` field: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to refer Localnet
instead of Layer2
.
modules/nw-cudn-localnet.adoc
Outdated
|
||
* You have logged in as a user with `cluster-admin` privileges. | ||
|
||
* You have created and configured the Open vSwitch (OVS) bridge mapping to associate the physical network with the interface label created by OVS. For more information, see "Configuration for a localnet switched topology". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this more confusing than it needs to - especially the "interface label" part.
What do we even mean w/ that ? The purpose of the bridge mappings is to associate the logical network (OVN) with a physical Kubernetes node interface via an OVS bridge (to which said interface is connected to).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rewrote this to try to clarify.
@JoeAldinger: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s):
Issue:
Link to docs preview:
QE review:
Additional information: