Skip to content

Conversation

@bscott-rh
Copy link
Contributor

@bscott-rh bscott-rh commented May 5, 2025

@bscott-rh bscott-rh added this to the Planned for 4.19 GA milestone May 5, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 5, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 5, 2025

🤖 Fri Jun 06 12:50:51 - Prow CI generated the docs preview:
https://93007--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@bscott-rh
Copy link
Contributor Author

@WenXinWei @vr4manta Hi Neil and Wenxin, please take a look at this PR showing the install config parameters for multi disk support on vsphere for 4.19. Thank you

@vr4manta
Copy link

looks good to me.

@WenXinWei
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2025
@bscott-rh bscott-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 6, 2025
@shreyasiddhartha
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 6, 2025
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, otherwise LGTM! :)

@xenolinux PTAL!

Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Follow-up review done. Overall LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 6, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2025

@bscott-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bscott-rh bscott-rh merged commit 482197b into openshift:main Jun 6, 2025
2 checks passed
@bscott-rh
Copy link
Contributor Author

/cherrypick enterprise-4.19

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #94382

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants