-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-14533 adding tech preview params for vsphere multi disk #93007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Fri Jun 06 12:50:51 - Prow CI generated the docs preview: |
|
@WenXinWei @vr4manta Hi Neil and Wenxin, please take a look at this PR showing the install config parameters for multi disk support on vsphere for 4.19. Thank you |
|
looks good to me. |
|
/lgtm |
|
/label peer-review-in-progress |
shreyasiddhartha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, otherwise LGTM! :)
@xenolinux PTAL!
xenolinux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment. Follow-up review done. Overall LGTM
|
New changes are detected. LGTM label has been removed. |
|
@bscott-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.19 |
|
@bscott-rh: new pull request created: #94382 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.19
Issue:
https://issues.redhat.com/browse/OSDOCS-14553
Link to docs preview:
https://93007--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_vsphere/installation-config-parameters-vsphere#installation-configuration-parameters-optional-vsphere_installation-config-parameters-vsphere
QE review:
Release notes PR will contain additional tech preview information.