Skip to content

CNV-56323: Added UI procedure for VM interface link state #93115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sjhala-ccs merged 1 commit into from
May 20, 2025
Merged

CNV-56323: Added UI procedure for VM interface link state #93115

sjhala-ccs merged 1 commit into from
May 20, 2025

Conversation

@sjhala-ccs
Copy link
Contributor

@sjhala-ccs sjhala-ccs commented May 7, 2025 •
edited
Loading

Version(s): 4.19+

Issue: CNV-56323

Link to docs preview: https://93115--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-setting-interface-link-state.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2025 •
edited by openshift-ci bot
Loading

@sjhala-ccs: This pull request references CNV-56323 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.19+

Issue: CNV-56323

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2025 •
edited by openshift-ci bot
Loading

@sjhala-ccs: This pull request references CNV-56323 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.19+

Issue: CNV-56323

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 7, 2025
@sjhala-ccs sjhala-ccs added CNV Label for all CNV PRs branch/enterprise-4.19 labels May 7, 2025
@sjhala-ccs sjhala-ccs added this to the Planned for 4.19 GA milestone May 7, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 7, 2025 •
edited
Loading

🤖 Mon May 19 18:52:48 - Prow CI generated the docs preview:

https://93115--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-setting-interface-link-state.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2025 •
edited by openshift-ci bot
Loading

@sjhala-ccs: This pull request references CNV-56323 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.19+

Issue: CNV-56323

Link to docs preview: https://93115--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-setting-interface-link-state.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

orelmisan
orelmisan approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@orelmisan orelmisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sjhala-ccs!

@sjhala-ccs sjhala-ccs requested a review from gouyang May 19, 2025 18:01
@sjhala-ccs sjhala-ccs added the peer-review-needed Signifies that the peer review team needs to review this PR label May 19, 2025
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 19, 2025
lahinson
lahinson reviewed May 19, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one tiny suggestion.

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 19, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 19, 2025

@sjhala-ccs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gouyang
Copy link

gouyang commented May 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 20, 2025 •
edited by openshift-ci bot
Loading

@sjhala-ccs: This pull request references CNV-56323 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.19+

Issue: CNV-56323

Link to docs preview: https://93115--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-setting-interface-link-state.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sjhala-ccs sjhala-ccs merged commit a549c53 into openshift:main May 20, 2025
2 checks passed
@sjhala-ccs
Copy link
Contributor Author

sjhala-ccs commented May 20, 2025

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 20, 2025

@sjhala-ccs: new pull request created: #93576

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 20, 2025
Merged
@sjhala-ccs sjhala-ccs deleted the cnv-56323 branch May 20, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahinson lahinson lahinson left review comments

@gouyang gouyang Awaiting requested review from gouyang

+1 more reviewer

@orelmisan orelmisan orelmisan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gouyang gouyang

Labels

branch/enterprise-4.19 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Planned for 4.19 GA

Development

Successfully merging this pull request may close these issues.

7 participants

@sjhala-ccs @openshift-ci-robot @ocpdocs-previewbot @gouyang @openshift-cherrypick-robot @orelmisan @lahinson