-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OBSDOCS-1779: Logging uninstalling steps #93208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enterprise-4.18
Are you sure you want to change the base?
Conversation
/test all |
Skipping CI for Draft Pull Request. |
@theashiot: This pull request references OBSDOCS-1779 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test all |
@theashiot: This pull request references OBSDOCS-1779 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@theashiot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general things to improve:
- Re-title PR to "Logging uninstalling steps"
- Renaming the modules to better reflect what they are about. For the instalation steps we named them according to console/cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instructions should be updated to instruct the user how to do it for Logging instead of generic instructions
- Deleting the
cluster-logging
- Deleting the
loki-operator
- Optionally deleting
pvcs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Process is not up to date. This reflects the steps for Logging 5.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First 2 steps of .Procedure
are not correct since UI doesn't behave this way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This procedure should be the last step in the "uninstalation". Also:
- introduction text here is confusing
- Procedure is not clear to users what they should be deleting
Version(s): 4.18
Issue: https://issues.redhat.com/browse/OBSDOCS-1779
Link to docs preview:
QE review:
Additional information: