Skip to content

OBSDOCS-1779: Logging uninstalling steps #93208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: enterprise-4.18
Choose a base branch
from

Conversation

@theashiot
Copy link
Contributor Author

/test all

Copy link

openshift-ci bot commented May 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 12, 2025

@theashiot: This pull request references OBSDOCS-1779 which is a valid jira issue.

In response to this:

Version(s): 4.18

Issue: https://issues.redhat.com/browse/OBSDOCS-1779

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2025
@theashiot
Copy link
Contributor Author

/test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 12, 2025

@theashiot: This pull request references OBSDOCS-1779 which is a valid jira issue.

In response to this:

Version(s): 4.18

Issue: https://issues.redhat.com/browse/OBSDOCS-1779

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented May 12, 2025

@theashiot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general things to improve:

  • Re-title PR to "Logging uninstalling steps"
  • Renaming the modules to better reflect what they are about. For the instalation steps we named them according to console/cli

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions should be updated to instruct the user how to do it for Logging instead of generic instructions

  1. Deleting the cluster-logging
  2. Deleting the loki-operator
  3. Optionally deleting pvcs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Process is not up to date. This reflects the steps for Logging 5.x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First 2 steps of .Procedure are not correct since UI doesn't behave this way

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This procedure should be the last step in the "uninstalation". Also:

  1. introduction text here is confusing
  2. Procedure is not clear to users what they should be deleting

@theashiot theashiot changed the title OBSDOCS-1779: Not installation, operator upgrade or uninstalling step… OBSDOCS-1779: Logging uninstalling steps May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants