Skip to content

OBSDOCS-1862: Add missing info about alert emails #93264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OBSDOCS-1862: Add missing info about alert emails #93264

wants to merge 1 commit into from
+39 −3

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented May 13, 2025 •
edited
Loading

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2025 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1862 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.12 +

Issue: https://issues.redhat.com/browse/OBSDOCS-1862

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 13, 2025 •
edited
Loading

🤖 Fri May 16 10:55:20 - Prow CI generated the docs preview:

https://93264--ocpdocs-pr.netlify.app/openshift-dedicated/latest/observability/monitoring/managing-alerts.html
https://93264--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/configuring-core-platform-monitoring/configuring-alerts-and-notifications.html
https://93264--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/observability/monitoring/managing-alerts.html
https://93264--ocpdocs-pr.netlify.app/openshift-rosa/latest/observability/monitoring/managing-alerts.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2025 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1862 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.12 +

Issue: https://issues.redhat.com/browse/OBSDOCS-1862

Link to docs preview: https://93264--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/configuring-core-platform-monitoring/configuring-alerts-and-notifications.html#configuring-alert-routing-default-platform-alerts_configuring-alerts-and-notifications

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@juzhao
Copy link

juzhao commented May 14, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2025 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-1862 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.12 +

Issue: https://issues.redhat.com/browse/OBSDOCS-1862

Link to docs preview: https://93264--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/configuring-core-platform-monitoring/configuring-alerts-and-notifications.html#configuring-alert-routing-default-platform-alerts_configuring-alerts-and-notifications

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 14, 2025
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 14, 2025
@xenolinux xenolinux added this to the Continuous Release milestone May 14, 2025
xenolinux
xenolinux reviewed May 14, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits; overall LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 14, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 15, 2025

New changes are detected. LGTM label has been removed.

@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 15, 2025
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 15, 2025
jeana-redhat
jeana-redhat approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 15, 2025
jeana-redhat
jeana-redhat reviewed May 15, 2025
View reviewed changes
modules/monitoring-configuring-alert-routing-default-platform-alerts.adoc Outdated
smarthost: 'smtp.example.com:587' # <3>
auth_username: [email protected] # <4>
auth_password: password
hello: alermanager # <5>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed this as I closed the preview tab - typo?

Suggested change
hello: alermanager # <5>
hello: alertmanager # <5>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, thanks for noticing! Fixing it right away!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@eromanova97
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 16, 2025

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

@jeana-redhat jeana-redhat jeana-redhat approved these changes

Assignees

@juzhao juzhao

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@eromanova97 @openshift-ci-robot @ocpdocs-previewbot @juzhao @xenolinux @jeana-redhat