OCPBUGS#55102: Include reserved HCP CIDR ranges #93269
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/S
xenolinux
force-pushed
the
hcp-reserved-cidr
branch
from
e75bd2c to
bc9d59a
Compare
openshift-ci
bot
added
size/M
|
/lgtm |
xenolinux
added
peer-review-needed
xenolinux
force-pushed
the
hcp-reserved-cidr
branch
from
bc9d59a to
793ce82
Compare
|
New changes are detected. LGTM label has been removed. |
xenolinux
force-pushed
the
hcp-reserved-cidr
branch
from
793ce82 to
6f5ceca
Compare
xenolinux
added
peer-review-needed
xenolinux
force-pushed
the
hcp-reserved-cidr
branch
from
6f5ceca to
0e04a0f
Compare
|
@xenolinux: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
xenolinux
added
the
peer-review-needed
jeana-redhat
added
the
peer-review-in-progress
| [id="hcp-cidr-ranges_{context}"] | ||
| = CIDR ranges for {hcp} | ||
|
|
||
| For deploying {hcp} on {product-title}, consider the following required Classless Inter-Domain Routing (CIDR) subnet ranges: |
There was a problem hiding this comment.
If these are required, should we use a more active verb like "use" or "adhere to"?
Suggested change
| For deploying {hcp} on {product-title}, consider the following required Classless Inter-Domain Routing (CIDR) subnet ranges: | |
| For deploying {hcp} on {product-title}, use the following required Classless Inter-Domain Routing (CIDR) subnet ranges: |
| // | ||
| // * hosted_control_planes/hcp-prepare/hcp-requirements.adoc | ||
|
|
||
| :_mod-docs-content-type: CONCEPT |
There was a problem hiding this comment.
Suggested change
| :_mod-docs-content-type: CONCEPT | |
| :_mod-docs-content-type: REFERENCE |
Comment on lines
+126
to
+133
| == {hcp-capital} CIDR | ||
|
|
||
| For {hcp} on {product-title}, consider the following required CIDR ranges: | ||
|
|
||
| * `v4InternalSubnet`: 100.65.0.0/16 (OVN-Kubernetes) | ||
| * `clusterNetwork`: 10.132.0.0/14 (pod network) | ||
| * `serviceNetwork`: 172.31.0.0/16 |
There was a problem hiding this comment.
If this content needs to be maintained at all (like if there will be changes to this list), finding a way to write it only once and reuse it in both places will avoid errors creeping in from folks not realizing there are two versions of the same content in the repo. Maybe a snippet, or just including the module in this assembly?
openshift-ci
bot
added
peer-review-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s): 4.17+
Issue: https://issues.redhat.com/browse/OCPBUGS-55102
Link to docs preview:
https://93269--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-prepare/hcp-requirements#hcp-cidr-ranges_hcp-requirements
https://93269--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/cidr-range-definitions.html#hcp-cidr-description_cidr-range-definitions
QE review:
Additional information: