TRACING-5364: RHOSDT 3.6 add tailsampling #93290
Conversation
Signed-off-by: Pavol Loffay <[email protected]>
|
@pavolloffay: This pull request references TRACING-5364 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
size/L
|
/test all |
|
🤖 Tue May 13 14:37:27 - Prow CI generated the docs preview: |
| <6> Policy to sample based on number attributes (resource and record). | ||
| <7> Policy to sample a percentage of traces. | ||
| <8> Policy to sample based upon the status code (OK, ERROR or UNSET). | ||
| <9> Policy to sample based on string attributes (resource and record) value matches, both exact and regex value matches are supported. |
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'regular expression' rather than 'regex'. For more information, see RedHat.TermsErrors.
|
@pavolloffay: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| Each policy will result in a decision, and the processor will evaluate them to make a final decision: | ||
|
|
||
| * When there's a "drop" decision, the trace is not sampled; | ||
| * When there's a "sample" decision, the trace is sampled; | ||
| * In all other cases, the trace is NOT sampled |
There was a problem hiding this comment.
@pavolloffay, are decisions to drop or sample individual traces anyhow visible to the user (like in a log or UI?) or is this processor, loosely speaking, a black box system?
I see that there is some statistical tracking available, but I'm wondering about inspecting specific traces.
There was a problem hiding this comment.
There are metrics exposed by the processor which can help to understand its behavior https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/tailsamplingprocessor#tracking-sampling-policy
It would be maybe good to document them. Do you want me to update the PR or do you prefer to do it yourself?
There was a problem hiding this comment.
Thank you. Let me try. If it's too difficult for me, I'll ask for your help.
Version(s):
OCP 4.12-4.19
RHOSDT 3.6
The feature is tech-preview.
Issue:
https://issues.redhat.com/browse/TRACING-5364
Link to docs preview:
QE review:
Additional information: