[OCPBUGS-56165]IBMZ changes for Multipath support for ABI #93336
Conversation
openshift-ci
bot
added
the
size/M
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
/ok-to-test |
| [NOTE] | ||
| ==== | ||
| For FCP multipath configurations, provide two disks instead of one. | ||
| ==== | ||
| + | ||
| .Example | ||
| [source,yaml] | ||
| ---- | ||
| rd.zfcp=<adapter1>,<wwpn1>,<lun1> \ | ||
| rd.zfcp=<adapter2>,<wwpn2>,<lun2> | ||
| ---- |
There was a problem hiding this comment.
If you look in the preview of this PR, the addition of this note and code block breaks the formatting/order of callouts that follow this. You may want to try something like wrapping this content in an open delimiter block (see this page for more details), which will sort of put all of this content in a separate "block" of asciidoc text.
| [NOTE] | |
| ==== | |
| For FCP multipath configurations, provide two disks instead of one. | |
| ==== | |
| + | |
| .Example | |
| [source,yaml] | |
| ---- | |
| rd.zfcp=<adapter1>,<wwpn1>,<lun1> \ | |
| rd.zfcp=<adapter2>,<wwpn2>,<lun2> | |
| ---- | |
| -- | |
| [NOTE] | |
| ==== | |
| For FCP multipath configurations, provide two disks instead of one. | |
| ==== | |
| + | |
| .Example | |
| [source,yaml] | |
| ---- | |
| rd.zfcp=<adapter1>,<wwpn1>,<lun1> \ | |
| rd.zfcp=<adapter2>,<wwpn2>,<lun2> | |
| ---- | |
| -- |
| [NOTE] | ||
| ==== | ||
| For FCP multipath configurations, provide two disks instead of one. | ||
| ==== | ||
| + | ||
| .Example | ||
| [source,yaml] | ||
| ---- | ||
| rd.zfcp=<adapter1>,<wwpn1>,<lun1> \ | ||
| rd.zfcp=<adapter2>,<wwpn2>,<lun2> | ||
| ---- |
There was a problem hiding this comment.
Similar to the other comment, you would also want to try wrapping this content in the -- block:
| [NOTE] | |
| ==== | |
| For FCP multipath configurations, provide two disks instead of one. | |
| ==== | |
| + | |
| .Example | |
| [source,yaml] | |
| ---- | |
| rd.zfcp=<adapter1>,<wwpn1>,<lun1> \ | |
| rd.zfcp=<adapter2>,<wwpn2>,<lun2> | |
| ---- | |
| [NOTE] | |
| ==== | |
| For FCP multipath configurations, provide two disks instead of one. | |
| ==== | |
| + | |
| -- | |
| .Example | |
| [source,yaml] | |
| ---- | |
| rd.zfcp=<adapter1>,<wwpn1>,<lun1> \ | |
| rd.zfcp=<adapter2>,<wwpn2>,<lun2> | |
| ---- | |
| -- |
There was a problem hiding this comment.
Let me try it out these suggestions
| [NOTE] | ||
| ==== | ||
| This parameter is mandatory for FCP multipath configurations on {ibm-z-name}. | ||
| ==== |
There was a problem hiding this comment.
Same thing here:
| [NOTE] | |
| ==== | |
| This parameter is mandatory for FCP multipath configurations on {ibm-z-name}. | |
| ==== | |
| -- | |
| [NOTE] | |
| ==== | |
| This parameter is mandatory for FCP multipath configurations on {ibm-z-name}. | |
| ==== | |
| -- |
lg-rh
force-pushed
the
ibmz_abi_4.19
branch
3 times, most recently
from
4799f44 to
d26b764
Compare
|
@lg-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/lgtm |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
lpettyjo
added
peer-review-in-progress
lpettyjo
added
peer-review-done
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
Version(s): 4.19+
Issue:
https://issues.redhat.com/browse/OCPBUGS-56165
Link to docs preview:
https://93336--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_with_agent_based_installer/installing-using-iscsi.html
https://93336--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_with_agent_based_installer/installing-with-agent-based-installer.html
https://93336--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_with_agent_based_installer/prepare-pxe-assets-agent.html
QE review:
Additional information: